From b9dca110b1bc5cc9ca0f0daf0b64974a0a56e8e2 Mon Sep 17 00:00:00 2001 From: "David C. Partridge" Date: Sun, 2 Apr 2023 10:20:31 +0100 Subject: [PATCH 1/3] Ensure the star deteciton threshold is set to the value from the workspace as the dialog is initialised. This prevents setting a value of 0 on exit. --- DeepSkyStacker/RegisterSettings.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/DeepSkyStacker/RegisterSettings.cpp b/DeepSkyStacker/RegisterSettings.cpp index 8559c54d5..a938a8a25 100644 --- a/DeepSkyStacker/RegisterSettings.cpp +++ b/DeepSkyStacker/RegisterSettings.cpp @@ -146,6 +146,7 @@ void RegisterSettings::onInitDialog() ui->luminanceThreshold-> setSliderPosition(value); ui->luminancePercent->setText(QString("%1%").arg(value)); + detectionThreshold = value; ui->medianFilter-> setChecked(workspace->value("Register/ApplyMedianFilter", false).toBool()); From c291d8aad23825c87a7d2ca3d3d62c475a436f8e Mon Sep 17 00:00:00 2001 From: "David C. Partridge" Date: Sun, 2 Apr 2023 11:05:38 +0100 Subject: [PATCH 2/3] Eensure that reference frame is used a) when checked, and b) when not checked --- DeepSkyStacker/FrameList.cpp | 1 - DeepSkyStacker/StackingEngine.cpp | 8 ++++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/DeepSkyStacker/FrameList.cpp b/DeepSkyStacker/FrameList.cpp index 2e03906e6..a9e42a7c5 100644 --- a/DeepSkyStacker/FrameList.cpp +++ b/DeepSkyStacker/FrameList.cpp @@ -205,7 +205,6 @@ namespace DSS for (auto it = group.pictures->cbegin(); it != group.pictures->cend(); ++it) { if (it->IsLightFrame() && - it->m_bChecked == Qt::Checked && it->m_bUseAsStarting ) { diff --git a/DeepSkyStacker/StackingEngine.cpp b/DeepSkyStacker/StackingEngine.cpp index 7a35f5a29..2fb5c5b9a 100644 --- a/DeepSkyStacker/StackingEngine.cpp +++ b/DeepSkyStacker/StackingEngine.cpp @@ -452,7 +452,11 @@ bool CStackingEngine::AddLightFramesToList(CAllStackingTasks& tasks) lfi = bitmap; lfi.RefreshSuperPixel(); - if (!m_strReferenceFrame.CompareNoCase(lfi.filePath.c_str())) + // + // m_strReferenceFrame is a CString but contains the reference frame path + // with / separators rather than \\ + // + if (!m_strReferenceFrame.CompareNoCase(lfi.filePath.generic_wstring().c_str())) { lfi.m_bStartingFrame = true; bReferenceFrameFound = true; @@ -816,7 +820,7 @@ void CStackingEngine::ComputeOffsets() const int lLast = static_cast(m_vBitmaps.size() * m_fKeptPercentage / 100.0); if (m_pProgress) - m_pProgress->Start1(strText, lLast, false); + m_pProgress->Start1(strText, lLast, true); // The first bitmap is the best one if (m_vBitmaps.size() > 1) From ee1c32ff7a686b6c9c540c06c0dfb9d1b2df0916 Mon Sep 17 00:00:00 2001 From: "David C. Partridge" Date: Sun, 2 Apr 2023 11:05:54 +0100 Subject: [PATCH 3/3] Update readme --- Installers/README.txt | 54 ++++++++++++++++++------------------------- 1 file changed, 23 insertions(+), 31 deletions(-) diff --git a/Installers/README.txt b/Installers/README.txt index 46ddf0d21..5bab958dd 100644 --- a/Installers/README.txt +++ b/Installers/README.txt @@ -3,59 +3,51 @@ Only 64 bit versions of Windows 10 and later are supported in this release. -Changes since the last release: +This is a bug fix release for problems reported against 5.1.0, 5.1.1, 5.1.2 -1. Bug fix - correct problems with drag drop of a directory. - -2. Enhancement - if Custom Rectangle mode is read from a filelist or settings file, switch to Intersection mode. - -3. Bug fix - correct handling of reference frame in filelist. - -4. Bug Fix - FITS/DDP choice of Camera was not being handled correctly. +1. Possible bug fix - DeepSkyStacker terminated at startup when running on ARM version of Windows 11 in x64 emulation mode. Unable to test. -Welcome to DeepSkyStacker 5.1.2 -=============================== +2. Bug fix - A corrupt info.txt file caused an infinite loop. -Only 64 bit versions of Windows 10 and later are supported in this release. +3. Diagnostic added - Report processor architecture and processor type in trace file and to stderr at startup. -This is a bug fix release for problems reported against 5.1.0 and 5.1.1 +4. Bug fix - Stacked FITS images in SuperPixel mode were displayed only in the top left corner. -1. Bug fix - correct handling of file types (TIFF/FITS) in DeepSkyStackerCL for intermediate and final files +5. Bug fix - Resolve occasional odd problems when using edit stars mode. -2. Bug fix - correct handling of Stacking Mode (Standard/Mosaic/Intersection/Custom) +6. Bug fix - DeepSkyStackerCL was only displaying the help text regardless of command line input. -3. Bug fix - unable to select a custom rectangle immediately after opening image file +7. Enhancement - Reinstate Image Properties as a Qt based dialogue to allow changing e.g. exposure for multiple images at once -4. Bug fix - fileids in filelist files were being incorrectly written as ANSI not UTF8 +8. Bug fix - Fields in the image list and the group tabs were not updated when switching to another language. -5. Bug fix - the selection for a custom rectangle was not always visible +9. Bug fix - remove all "Set Black Point to Zero" recommendations from "Recommended Settings" -6. Enhancement - reduce the minium size for the image list to be two rows +10. Bug fix - Invalid input in RAW/DDP settings for scale factors caused an assertion failure -Welcome to DeepSkyStacker 5.1.1 -=============================== +11. Bug fix - correct handling of file types (TIFF/FITS) in DeepSkyStackerCL for intermediate and final files -This is a bug fix release for problems reported against 5.1.0 +12. Bug fix - correct handling of Stacking Mode (Standard/Mosaic/Intersection/Custom) -1. Possible bug fix - DeepSkyStacker terminated at startup when running on ARM version of Windows 11 in x64 emulation mode. Unable to test. +13. Bug fix - unable to select a custom rectangle immediately after opening image file -2. Bug fix - A corrupt info.txt file caused an infinite loop. +14. Bug fix - fileids in filelist files were being incorrectly written as ANSI not UTF8 -3. Diagnostic added - Report processor architecture and processor type in trace file and to stderr at startup. +15. Bug fix - the selection for a custom rectangle was not always visible -4. Bug fix - Stacked FITS images in SuperPixel mode were displayed only in the top left corner. +16. Enhancement - reduce the minimum size for the image list to be two rows -5. Bug fix - Resolve occasional odd problems when using edit stars mode. +17. Bug fix - correct problems with drag drop of a directory. -6. Bug fix - DeepSkyStackerCL was only displaying the help text regardless of command line input. +18. Enhancement - if Custom Rectangle mode is read from a filelist or settings file, switch to Intersection mode. -7. Enhancement - Reinstate Image Properties as a Qt based dialogue to allow changing e.g. exposure for multiple images at once +19. Bug fix - correct handling of reference frame in filelist. -8. Bug fix - Fields in the image list and the group tabs were not updated when switching to another language. +20. Bug Fix - FITS/DDP choice of Camera was not being handled correctly. -9. Bug fix - remove all "Set Black Point to Zero" recommendations from "Recommended Settings" +21. Bug fix - ensure that reference frame is used a) when checked, and b) when not checked -10. Bug fix - Invalid input in RAW/DDP settings for scale factors caused an assertion failure +22. Bug fix - Register settings set a value of 0 for the luminance threshold when it was initially set to 20. Welcome to DeepSkyStacker 5.1.0 ===============================