Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] issue with format 'qe/pw/scf' #268

Closed
zyliu06 opened this issue Apr 12, 2022 · 3 comments
Closed

[BUG] issue with format 'qe/pw/scf' #268

zyliu06 opened this issue Apr 12, 2022 · 3 comments
Labels
bug Something isn't working qe

Comments

@zyliu06
Copy link

zyliu06 commented Apr 12, 2022

Summary

The format 'qe/pw/scf' does not give correct atomic coordinate when the input 'ATOMIC_POSITIONS' is written in 'crystal' and the lattice matrix 'cell' is not equal to its transpose 'cell.T'.

The 'cell' matrix is not supposed to be transposed when converting the fractional coordinate to cartesian coordinate.

dpdata Version

0.2.5

Links

https://github.com/deepmodeling/dpdata/blob/master/dpdata/qe/scf.py#L73

@zyliu06 zyliu06 added the bug Something isn't working label Apr 12, 2022
@wanghan-iapcm
Copy link
Contributor

@Liu-RX Could you please take a look? Thanks!

@Liu-RX
Copy link
Contributor

Liu-RX commented Apr 13, 2022

@Liu-RX Could you please take a look? Thanks!

I will fix the issue.

@Liu-RX
Copy link
Contributor

Liu-RX commented Apr 13, 2022

I have checked the code and I think it should be coord = np.matmul(coord, cell) rather than coord = np.matmul(coord, cell.T)? I will fix it in the next pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working qe
Projects
None yet
Development

No branches or pull requests

4 participants