Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement additional tebd_input_mode options in se_atten #3703

Closed
coderabbitai bot opened this issue Apr 23, 2024 · 0 comments · Fixed by #3712
Closed

Implement additional tebd_input_mode options in se_atten #3703

coderabbitai bot opened this issue Apr 23, 2024 · 0 comments · Fixed by #3712
Assignees
@iProzd
Labels
enhancement

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 23, 2024

This issue tracks the enhancement request to implement additional options in the class of the PyTorch model descriptor. This enhancement was discussed in PR #3696. For more context, see the discussion here: #3696 (comment)
@iProzd iProzd changed the title Implement additional options in Implement additional tebd_input_mode options in se_atten Apr 23, 2024
@iProzd iProzd self-assigned this Apr 23, 2024
@iProzd iProzd moved this to In review in DeePMD-3.0.0 beta release Apr 30, 2024
@njzjz njzjz linked a pull request May 2, 2024 that will close this issue
feat: Support stripped type embedding in DPA1 of PT/DP #3712
Merged
@iProzd iProzd closed this as completed May 6, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in DeePMD-3.0.0 beta release May 6, 2024
@coderabbitai coderabbitai bot mentioned this issue May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iProzd iProzd

Labels
enhancement
Projects
No open projects
DeePMD-3.0.0 beta release
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Support stripped type embedding in DPA1 of PT/DP iProzd/deepmd-kit
2 participants
@njzjz @iProzd