From d62a41f37388acd2b09e13a7554b68617612c4c2 Mon Sep 17 00:00:00 2001
From: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Date: Thu, 16 May 2024 14:48:02 -0400
Subject: [PATCH] tests: skip attention-related parameterize when attn_layer is
 0 (#3784)

The tests make no sense in this case.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
- Improved test coverage by adding an optional `temperature` parameter
to the attention layer tests.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
---
 .../tests/consistent/descriptor/test_dpa1.py  | 45 +++++++++++++++----
 1 file changed, 37 insertions(+), 8 deletions(-)

diff --git a/source/tests/consistent/descriptor/test_dpa1.py b/source/tests/consistent/descriptor/test_dpa1.py
index 5d1ad9ad47..5e9ea01602 100644
--- a/source/tests/consistent/descriptor/test_dpa1.py
+++ b/source/tests/consistent/descriptor/test_dpa1.py
@@ -2,6 +2,7 @@
 import unittest
 from typing import (
     Any,
+    Optional,
     Tuple,
 )
 
@@ -111,6 +112,15 @@ def data(self) -> dict:
             "seed": 1145141919810,
         }
 
+    def is_meaningless_zero_attention_layer_tests(
+        self,
+        attn_layer: int,
+        attn_dotr: bool,
+        normalize: bool,
+        temperature: Optional[float],
+    ) -> bool:
+        return attn_layer == 0 and (attn_dotr or normalize or temperature is not None)
+
     @property
     def skip_pt(self) -> bool:
         (
@@ -133,7 +143,12 @@ def skip_pt(self) -> bool:
             precision,
             use_econf_tebd,
         ) = self.param
-        return CommonTest.skip_pt
+        return CommonTest.skip_pt or self.is_meaningless_zero_attention_layer_tests(
+            attn_layer,
+            attn_dotr,
+            normalize,
+            temperature,
+        )
 
     @property
     def skip_dp(self) -> bool:
@@ -157,7 +172,12 @@ def skip_dp(self) -> bool:
             precision,
             use_econf_tebd,
         ) = self.param
-        return CommonTest.skip_pt
+        return CommonTest.skip_pt or self.is_meaningless_zero_attention_layer_tests(
+            attn_layer,
+            attn_dotr,
+            normalize,
+            temperature,
+        )
 
     @property
     def skip_tf(self) -> bool:
@@ -183,12 +203,21 @@ def skip_tf(self) -> bool:
         ) = self.param
         # TODO (excluded_types != [] and attn_layer > 0) need fix
         return (
-            env_protection != 0.0
-            or smooth_type_embedding
-            or not normalize
-            or temperature != 1.0
-            or (excluded_types != [] and attn_layer > 0)
-            or (type_one_side and tebd_input_mode == "strip")  # not consistent yet
+            CommonTest.skip_tf
+            or (
+                env_protection != 0.0
+                or smooth_type_embedding
+                or not normalize
+                or temperature != 1.0
+                or (excluded_types != [] and attn_layer > 0)
+                or (type_one_side and tebd_input_mode == "strip")  # not consistent yet
+            )
+            or self.is_meaningless_zero_attention_layer_tests(
+                attn_layer,
+                attn_dotr,
+                normalize,
+                temperature,
+            )
         )
 
     tf_class = DescrptDPA1TF