fix(sql): repair & enable @deepkit/sql tests #579
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
@deepkit/sql tests should have been failing since the addition of:
https://github.com/deepkit/deepkit-framework/blame/v1.0.1-alpha.153/packages/sql/src/sql-filter-builder.ts#L31
where the following wasn't updated:
https://github.com/deepkit/deepkit-framework/blame/v1.0.1-alpha.153/packages/sql/tests/sql-query.spec.ts#L103
I discovered packages/sql isn't being tested.
Relinquishment of Rights
Please mark following checkbox to confirm that you relinquish all rights of your changes: