Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql): repair & enable @deepkit/sql tests #579

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

fergusean
Copy link
Contributor

Summary of changes

@deepkit/sql tests should have been failing since the addition of:
https://github.com/deepkit/deepkit-framework/blame/v1.0.1-alpha.153/packages/sql/src/sql-filter-builder.ts#L31

where the following wasn't updated:
https://github.com/deepkit/deepkit-framework/blame/v1.0.1-alpha.153/packages/sql/tests/sql-query.spec.ts#L103

I discovered packages/sql isn't being tested.

Relinquishment of Rights

Please mark following checkbox to confirm that you relinquish all rights of your changes:

  • I waive and relinquish all rights regarding this changes (including code, text, and images) to Deepkit UG (limited), Germany. This changes (including code, text, and images) are under MIT license without name attribution, copyright notice, and permission notice requirement.

@marcj marcj merged commit 81a1ab1 into deepkit:master Jun 21, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants