Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql): dates should be nullable without casting as JSON #553

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

fergusean
Copy link
Contributor

Summary of changes

Same as #552, but for dates. Can't use Date | null on SQL entities right now without Deepkit trying to cast them as JSON into the database.

Relinquishment of Rights

Please mark following checkbox to confirm that you relinquish all rights of your changes:

  • I waive and relinquish all rights regarding this changes (including code, text, and images) to Deepkit UG (limited), Germany. This changes (including code, text, and images) are under MIT license without name attribution, copyright notice, and permission notice requirement.

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.58%. Comparing base (51b9b36) to head (d146d79).

❗ Current head d146d79 differs from pull request most recent head c5760c1. Consider uploading reports for the commit c5760c1 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #553   +/-   ##
=======================================
  Coverage   78.58%   78.58%           
=======================================
  Files         193      193           
  Lines       20448    20448           
  Branches     5311     5311           
=======================================
  Hits        16070    16070           
  Misses       4378     4378           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fergusean fergusean force-pushed the fix-nullable-dates branch from bd9d5a5 to c5760c1 Compare March 23, 2024 05:41
@marcj marcj merged commit d34b1a3 into deepkit:master Mar 24, 2024
6 checks passed
@marcj
Copy link
Member

marcj commented Mar 24, 2024

thanks @fergusean! I also adjusted sqlite/postgres to use the new date type resolver ab12802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants