From 2ade1a4eae28762b328dc87bb8e6bb882a1e282e Mon Sep 17 00:00:00 2001
From: Matthew Runyon <matthewrunyon@deephaven.io>
Date: Tue, 13 Aug 2024 14:15:55 -0500
Subject: [PATCH] fix: Errors thrown during a grid update are not caught

---
 packages/grid/src/Grid.tsx | 21 ++++++++++++++++++++-
 1 file changed, 20 insertions(+), 1 deletion(-)

diff --git a/packages/grid/src/Grid.tsx b/packages/grid/src/Grid.tsx
index 8634b2be3..74c64f70b 100644
--- a/packages/grid/src/Grid.tsx
+++ b/packages/grid/src/Grid.tsx
@@ -197,6 +197,13 @@ export type GridState = {
   // Whether we're stuck to the bottom or the right
   isStuckToBottom: boolean;
   isStuckToRight: boolean;
+
+  /**
+   * Errors thrown during a render animation frame.
+   * These are not caught by the grid panel,
+   * so we need to throw them in componentDidUpdate
+   */
+  renderError?: unknown;
 };
 
 /**
@@ -497,6 +504,13 @@ class Grid extends PureComponent<GridProps, GridState> {
   }
 
   componentDidUpdate(prevProps: GridProps, prevState: GridState): void {
+    const { renderError } = this.state;
+
+    // Render errors mean we can't recover
+    if (renderError != null) {
+      throw renderError;
+    }
+
     const changedProps = getChangedKeys(prevProps, this.props);
     const changedState = getChangedKeys(prevState, this.state);
     // We don't need to bother re-checking any of the metrics if only the children have changed
@@ -811,7 +825,12 @@ class Grid extends PureComponent<GridProps, GridState> {
     this.animationFrame = requestAnimationFrame(() => {
       this.animationFrame = null;
 
-      this.updateCanvas();
+      try {
+        this.updateCanvas();
+      } catch (e) {
+        // Errors thrown from the animation frame are uncaught by the grid panel
+        this.setState({ renderError: e });
+      }
     });
   }