From 528b2c0ca51e728b19dd176f786f6d283329c380 Mon Sep 17 00:00:00 2001 From: Don McKenzie Date: Tue, 28 Feb 2023 15:57:51 -0500 Subject: [PATCH 1/3] feat: Improve text labels based on suggestions from chatGPT I asked chatGPT to help me brainstorm improvements to some of the labels and hint text based on the Apple Human Interface Guidelines. I then edited them as human to improve them further. --- .../src/settings/ColumnSpecificSectionContent.tsx | 5 ++--- .../src/settings/FormattingSectionContent.tsx | 4 ++-- packages/code-studio/src/settings/SettingsMenu.tsx | 4 ++-- .../code-studio/src/settings/ShortcutsSectionContent.tsx | 4 ++-- packages/iris-grid/src/IrisGrid.tsx | 2 +- packages/iris-grid/src/sidebar/AdvancedSettingsMenu.tsx | 4 ++-- packages/iris-grid/src/sidebar/RollupRows.tsx | 4 ++-- packages/iris-grid/src/sidebar/SelectDistinctBuilder.tsx | 9 +++------ 8 files changed, 16 insertions(+), 20 deletions(-) diff --git a/packages/code-studio/src/settings/ColumnSpecificSectionContent.tsx b/packages/code-studio/src/settings/ColumnSpecificSectionContent.tsx index 525af78bf9..802e9e43de 100644 --- a/packages/code-studio/src/settings/ColumnSpecificSectionContent.tsx +++ b/packages/code-studio/src/settings/ColumnSpecificSectionContent.tsx @@ -614,10 +614,9 @@ export class ColumnSpecificSectionContent extends PureComponent< return (
-
Default formatting for matched column names
- Applies a formatting rule to all columns that match a specified name - and type. + Customize the formatting of table columns by applying rules based on + matching both a column name and column type.
-
Default formatting for column types
- Applies a formatting rule to all columns of a set type. + Choose the default formatting rule to apply to all table columns + based on their type.
)} diff --git a/packages/iris-grid/src/sidebar/SelectDistinctBuilder.tsx b/packages/iris-grid/src/sidebar/SelectDistinctBuilder.tsx index ccee5af7f3..69b96081d6 100644 --- a/packages/iris-grid/src/sidebar/SelectDistinctBuilder.tsx +++ b/packages/iris-grid/src/sidebar/SelectDistinctBuilder.tsx @@ -161,12 +161,9 @@ class SelectDistinctBuilder extends Component<
- Modifies a table to show unique value from a column, same as{' '} - - selectDistinct("Column") - - . Filters will be reset and the resulting table will contain only - the selected columns above. + Display only unique values from the selected table columns. Note + that this will reset any filters and display only the selected + columns.
From ce5f89eda299d9d6503d020dad12918cae692839 Mon Sep 17 00:00:00 2001 From: Don Date: Tue, 28 Feb 2023 16:30:05 -0500 Subject: [PATCH 2/3] Update packages/code-studio/src/settings/SettingsMenu.tsx Co-authored-by: Mike Bender --- packages/code-studio/src/settings/SettingsMenu.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/code-studio/src/settings/SettingsMenu.tsx b/packages/code-studio/src/settings/SettingsMenu.tsx index 1020656108..605f7f6b38 100644 --- a/packages/code-studio/src/settings/SettingsMenu.tsx +++ b/packages/code-studio/src/settings/SettingsMenu.tsx @@ -163,7 +163,7 @@ export class SettingsMenu extends Component< transform="grow-4" className="mr-2" /> - Format by Column Name & Type + Format by Column Name & Type } onToggle={this.handleSectionToggle} From 3571ee65c47c4623e76f5de3509bf55c115c379c Mon Sep 17 00:00:00 2001 From: Don Date: Tue, 28 Feb 2023 16:51:48 -0500 Subject: [PATCH 3/3] Update packages/iris-grid/src/sidebar/AdvancedSettingsMenu.tsx --- packages/iris-grid/src/sidebar/AdvancedSettingsMenu.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/iris-grid/src/sidebar/AdvancedSettingsMenu.tsx b/packages/iris-grid/src/sidebar/AdvancedSettingsMenu.tsx index 107e7207e7..68089731d2 100644 --- a/packages/iris-grid/src/sidebar/AdvancedSettingsMenu.tsx +++ b/packages/iris-grid/src/sidebar/AdvancedSettingsMenu.tsx @@ -36,7 +36,7 @@ AdvancedSettingsMenu.getAdvancedSettingsTitleForKey = ( case AdvancedSettingsType.FILTER_CONTROL_CHANGE_CLEARS_ALL_FILTERS: return 'Clear current table filters before applying new filters from a control'; case AdvancedSettingsType.LINK_CHANGE_CLEARS_ALL_FILTERS: - return 'Clear current table filters before applying new filters from a incoming link filter'; + return 'Clear current table filters before applying new filters from an incoming link filter'; } };