diff --git a/README.md b/README.md index 5e776a9acc..a81f081293 100644 --- a/README.md +++ b/README.md @@ -34,11 +34,10 @@ We are still using node 16.x and npm 8.x. If you are [using nvm](https://github. - `npm run e2e`: Runs the Playwright end-to-end tests locally. - `npm run e2e:headed`: Runs end-to-end tests in headed mode debug mode. Useful if you need to debug why a particular test isn't work. For example, to debug the `table.spec.ts` test directly, you could run `npm run e2e:headed -- ./tests/table.spec.ts`. -Edit `.env.local` in each package to contain the following pointing to your local DHC address. These are needed for the session websocket and for things like notebooks to be proxied correctly by Vite. +If your DHC address is different from the default `http://localhost:10000`, edit `.env.local` in each package to point to your local DHC. This is needed for the session websocket and for things like notebooks to be proxied correctly by Vite. ``` -VITE_CORE_API_URL=http://localhost:10000/jsapi -VITE_PROXY_URL=http://localhost:10000 +VITE_PROXY_URL=http://: ``` ## Package Overview diff --git a/packages/code-studio/.env b/packages/code-studio/.env index 5096748708..162d2c4bb3 100644 --- a/packages/code-studio/.env +++ b/packages/code-studio/.env @@ -5,6 +5,7 @@ VITE_CORE_API_URL=/jsapi VITE_CORE_API_NAME=dh-core.js VITE_OPEN_API_NAME=dh-internal.js VITE_PLUGIN_URL=/ide/plugins/ +VITE_PROXY_URL=http://localhost:10000 VITE_NOTEBOOKS_URL=/notebooks VITE_LAYOUTS_URL=/layouts VITE_ENABLE_LOG_PROXY=true diff --git a/packages/code-studio/.env.development b/packages/code-studio/.env.development index 435b779fe8..4965764969 100644 --- a/packages/code-studio/.env.development +++ b/packages/code-studio/.env.development @@ -5,5 +5,3 @@ BASE_URL=/ VITE_INTERNAL_COMPONENT_PLUGINS=ExamplePlugin PORT=4000 VITE_LOG_LEVEL=4 - -VITE_PROXY_URL=http://localhost:10000 \ No newline at end of file diff --git a/packages/embed-chart/.env b/packages/embed-chart/.env index 5c3d56bf62..bcdccf5a84 100644 --- a/packages/embed-chart/.env +++ b/packages/embed-chart/.env @@ -5,3 +5,4 @@ VITE_CORE_API_NAME=dh-core.js VITE_BUILD_PATH=./build VITE_LOG_LEVEL=2 VITE_FAVICON=./favicon-cc-app.svg +VITE_PROXY_URL=http://localhost:10000 diff --git a/packages/embed-chart/.env.development b/packages/embed-chart/.env.development index d4a436f374..b9d0bee432 100644 --- a/packages/embed-chart/.env.development +++ b/packages/embed-chart/.env.development @@ -3,5 +3,3 @@ VITE_FAVICON=./favicon-cc-app-dev.svg # 4020 So not to conflict with code-studio PORT=4020 - -VITE_PROXY_URL=http://localhost:10000 \ No newline at end of file diff --git a/packages/embed-grid/.env b/packages/embed-grid/.env index 5c3d56bf62..bcdccf5a84 100644 --- a/packages/embed-grid/.env +++ b/packages/embed-grid/.env @@ -5,3 +5,4 @@ VITE_CORE_API_NAME=dh-core.js VITE_BUILD_PATH=./build VITE_LOG_LEVEL=2 VITE_FAVICON=./favicon-cc-app.svg +VITE_PROXY_URL=http://localhost:10000 diff --git a/packages/embed-grid/.env.development b/packages/embed-grid/.env.development index b98c681181..d555e97cda 100644 --- a/packages/embed-grid/.env.development +++ b/packages/embed-grid/.env.development @@ -3,5 +3,3 @@ VITE_FAVICON=./favicon-cc-app-dev.svg # 4010 So not to conflict with code-studio PORT=4010 - -VITE_PROXY_URL=http://localhost:10000 \ No newline at end of file