Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Console error when opening context menu on tree table (#2047) #2142

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

AkshatJawne
Copy link
Contributor

@AkshatJawne AkshatJawne commented Jul 12, 2024

Resolves #2029

Changes Implemented:

  • Added null check when call formatValue function, to ensure that it is only called when it is defined

…#2047)

Resolves deephaven#2029

**Changes Implemented:** 
- Added null check when call formatValue function, to ensure that
it is only called when it is defined

```
@AkshatJawne AkshatJawne requested a review from mofojed July 12, 2024 21:25
@AkshatJawne AkshatJawne self-assigned this Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 46.43%. Comparing base (3757163) to head (b710369).
Report is 2 commits behind head on release/v0.78.

Files Patch % Lines
packages/iris-grid/src/IrisGridTreeTableModel.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           release/v0.78    #2142   +/-   ##
==============================================
  Coverage          46.43%   46.43%           
==============================================
  Files                675      675           
  Lines              38841    38841           
  Branches            9830     9831    +1     
==============================================
  Hits               18037    18037           
  Misses             20751    20751           
  Partials              53       53           
Flag Coverage Δ
unit 46.43% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofojed mofojed merged commit dbd6c88 into deephaven:release/v0.78 Jul 15, 2024
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants