Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add JS Plugin Information #2002

Merged
merged 5 commits into from
May 15, 2024
Merged

feat: Add JS Plugin Information #2002

merged 5 commits into from
May 15, 2024

Conversation

AkshatJawne
Copy link
Contributor

@AkshatJawne AkshatJawne commented May 10, 2024 •
edited
Loading

Resolves #1374

Changes:

  • Added "Plugins" section to Settings sidebar, with the JS plugin and its corresponding version (see screenshot below)
  • Modified the PluginMap to be a mapping from a string to a VersionedPluginModule: which contains an optional version prop

Screenshot of Change:
image]
The plugin information looks the same, just now, when we click "Copy versions", the info about the plugins is also copied

@AkshatJawne AkshatJawne self-assigned this May 10, 2024
mofojed
mofojed requested changes May 10, 2024
View reviewed changes
packages/plugin/src/PluginTypes.ts Outdated Show resolved Hide resolved
packages/plugin/src/PluginTypes.ts Outdated Show resolved Hide resolved
packages/plugin/src/PluginTypes.ts Outdated Show resolved Hide resolved
packages/code-studio/src/settings/SettingsMenu.tsx Outdated Show resolved Hide resolved
@AkshatJawne AkshatJawne requested a review from mofojed May 13, 2024 18:15
mofojed
mofojed approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! As long as @dsmmcken has approved the styling/copy behaviour, this is good to merge.

@AkshatJawne AkshatJawne merged commit 6ff378c into deephaven:main May 15, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dsmmcken dsmmcken dsmmcken approved these changes

@mofojed mofojed mofojed approved these changes

@mattrunyon mattrunyon Awaiting requested review from mattrunyon

Assignees

@AkshatJawne AkshatJawne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add JS plugin information to Settings/Version information
4 participants
@AkshatJawne @dsmmcken @mofojed @mattrunyon