Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add DashboardPlugin support to embed-widget #1950

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

mattrunyon
Copy link
Collaborator

@mattrunyon mattrunyon commented Apr 19, 2024

Needed for deephaven/deephaven-plugins#215

Doesn't support multiple dashboards being opened in one embed, but some of the groundwork is there and we don't support multiple dashboards from a single widget anyway yet.

@mattrunyon mattrunyon self-assigned this Apr 19, 2024
@mattrunyon mattrunyon marked this pull request as ready for review April 20, 2024 05:28
@mattrunyon mattrunyon requested a review from mofojed April 20, 2024 05:28
Comment on lines +31 to +39
Object.entries(
layoutManager.config.settings.defaultComponentConfig ?? {}
).forEach(([k, v]) => {
// @ts-ignore
if (config[k] === undefined) {
// @ts-ignore
config[k] = v;
}
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annoying that Object.assign doesn't have something that does this, skipping undefined. Oh well.

Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's get this in

@mattrunyon mattrunyon merged commit 27fc8bd into deephaven:main Apr 24, 2024
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2024
@mattrunyon mattrunyon deleted the embed-ui branch June 23, 2024 06:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants