Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Loading workspace plugin data #1872

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Mar 15, 2024

  • When loading a default layout, the pluginDataMap wasn't getting pulled in

@mofojed mofojed requested a review from mattrunyon March 15, 2024 19:33
@mofojed mofojed self-assigned this Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 46.14%. Comparing base (6d1d791) to head (a3ad2cd).

Files Patch % Lines
...s/code-studio/src/storage/LocalWorkspaceStorage.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1872      +/-   ##
==========================================
- Coverage   46.15%   46.14%   -0.01%     
==========================================
  Files         636      636              
  Lines       38071    38072       +1     
  Branches     9627     9628       +1     
==========================================
  Hits        17570    17570              
- Misses      20448    20449       +1     
  Partials       53       53              
Flag Coverage Δ
unit 46.14% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofojed mofojed merged commit 1def969 into deephaven:main Mar 15, 2024
5 checks passed
@mofojed mofojed deleted the fix-local-workspace-data branch March 15, 2024 20:21
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants