Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard plugin that throws error crashes UI #1771

Closed
mofojed opened this issue Feb 5, 2024 · 0 comments · Fixed by #2080
Closed

Dashboard plugin that throws error crashes UI #1771

mofojed opened this issue Feb 5, 2024 · 0 comments · Fixed by #2080
Assignees
Labels
bug Something isn't working
Milestone

Comments

@mofojed
Copy link
Member

mofojed commented Feb 5, 2024

Description

If you run a dashboard plugin that throws in the render cycle, it will crash DH. Instead, it should just log an error and not crash the application.

Steps to reproduce

  1. Modify a DashboardPlugin to throw in render
  2. Start up the UI

Expected results
2. UI should start, with an error logged about the dashboard plugin that threw

Actual results
2. Deephaven UI crashes.

@mofojed mofojed added bug Something isn't working triage Issue requires triage labels Feb 5, 2024
@vbabich vbabich added this to the February 2024 milestone Feb 6, 2024
@vbabich vbabich removed the triage Issue requires triage label Feb 6, 2024
@mofojed mofojed modified the milestones: February 2024, March 2024 Mar 12, 2024
@mofojed mofojed modified the milestones: March 2024, April 2024 Apr 12, 2024
@mofojed mofojed modified the milestones: April 2024, May 2024 May 13, 2024
@AkshatJawne AkshatJawne self-assigned this May 16, 2024
@mofojed mofojed modified the milestones: May 2024, June 2024 Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants