Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Made WidgetComponentProps generic #1760

Merged
merged 1 commit into from
Jan 30, 2024
Merged

fix: Made WidgetComponentProps generic #1760

merged 1 commit into from
Jan 30, 2024

Conversation

bmingles
Copy link
Contributor

@bmingles bmingles commented Jan 30, 2024 •
edited
Loading

Made PluginType generic. This fixes a breaking change that impacts PlotlyExpressChartPanel and PlotlyExpressChart in the plugins repo so that our next version bump will be cleaner.

fixes #1759

@bmingles bmingles requested a review from mofojed January 30, 2024 21:02
@bmingles bmingles merged commit 8cb0a10 into deephaven:main Jan 30, 2024
11 checks passed
@bmingles bmingles deleted the 1759-widget-plugin-type-generic branch January 30, 2024 21:26
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mofojed mofojed mofojed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WidgetPlugin type should be generic
2 participants
@bmingles @mofojed