Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix useDeferredApi export #1742

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Jan 23, 2024

  • It wasn't actually being exported
  • Also add a DeferredApiBootstrap component to gate on loading the API

- It wasn't actually being exported
- Also add a DeferredApiBootstrap component to gate on loading the API
@mofojed mofojed requested a review from vbabich January 23, 2024 03:01
@mofojed mofojed self-assigned this Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (45fa929) 46.04% compared to head (aa68096) 46.05%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1742      +/-   ##
==========================================
+ Coverage   46.04%   46.05%   +0.01%     
==========================================
  Files         621      622       +1     
  Lines       37454    37465      +11     
  Branches     9413     9415       +2     
==========================================
+ Hits        17244    17254      +10     
- Misses      20156    20157       +1     
  Partials       54       54              
Flag Coverage Δ
unit 46.05% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofojed mofojed enabled auto-merge (squash) January 25, 2024 19:36
@mofojed mofojed merged commit af5f5f4 into deephaven:main Jan 25, 2024
5 checks passed
@mofojed mofojed deleted the use-deferred-api branch January 25, 2024 19:44
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants