Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add pluginDataMap to redux, add useDashboardPluginData hook #1737

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

vbabich
Copy link
Collaborator

@vbabich vbabich commented Jan 19, 2024

Add useDashboardPluginData hook for accessing plugin data in redux

@vbabich vbabich changed the title Add pluginDataMap to redux, add useDashboardPluginData hook feat: Add pluginDataMap to redux, add useDashboardPluginData hook Jan 19, 2024
@vbabich vbabich self-assigned this Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (a3bea73) 46.44% compared to head (ae10ae6) 46.05%.
Report is 20 commits behind head on main.

Files Patch % Lines
packages/dashboard/src/redux/hooks.ts 0.00% 7 Missing ⚠️
packages/dashboard/src/redux/actions.ts 33.33% 2 Missing ⚠️
packages/dashboard/src/redux/selectors.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1737      +/-   ##
==========================================
- Coverage   46.44%   46.05%   -0.40%     
==========================================
  Files         611      623      +12     
  Lines       37204    37514     +310     
  Branches     9363     9433      +70     
==========================================
- Hits        17279    17276       -3     
- Misses      19871    20184     +313     
  Partials       54       54              
Flag Coverage Δ
unit 46.05% <21.42%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to clean up the hook used in a bit.

Side note, ideally we'd have the plugins wrapped in a context such that they don't need to self-report their pluginId - we could have a situation here where a plugin is reading/writing another plugins data, and/or doesn't use it's actual pluginId. But that seems more like a convenience thing (security-wise we're already storing the data in redux which is accessible by all).

packages/dashboard/src/redux/hooks.ts Outdated Show resolved Hide resolved
@vbabich vbabich requested a review from mofojed January 25, 2024 22:32
@vbabich vbabich merged commit e1b4562 into deephaven:main Jan 26, 2024
4 of 5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants