fix: loading spinner finishes before all series load #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1729 +/- ##
==========================================
- Coverage 46.68% 46.47% -0.21%
==========================================
Files 609 617 +8
Lines 36985 37298 +313
Branches 9306 9379 +73
==========================================
+ Hits 17265 17333 +68
- Misses 19668 19911 +243
- Partials 52 54 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mofojed
approved these changes
Jan 17, 2024
| @@ -157,6 +157,9 @@ class FigureChartModel extends ChartModel { | |||
| const { charts } = this.figure; | |||
| const axisTypeMap = ChartUtils.getAxisTypeMap(this.figure); | |||
| const activeSeriesNames: string[] = []; | |||
There was a problem hiding this comment.
Side note - this could be optimized by using a Set<string> instead of a string[].
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1654