Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added test:debug script #1628

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Conversation

bmingles
Copy link
Contributor

@bmingles bmingles commented Nov 6, 2023

Added a test:debug npm script.

resolves #1627

Copy link
Collaborator

@mattrunyon mattrunyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I think the version I had for debugging before didn't work in watch mode, so nice to have it (as well as have it documented)

README.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (61d1a53) 46.71% compared to head (e93e928) 46.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1628   +/-   ##
=======================================
  Coverage   46.71%   46.71%           
=======================================
  Files         583      583           
  Lines       36308    36308           
  Branches     9094     9094           
=======================================
  Hits        16961    16961           
  Misses      19295    19295           
  Partials       52       52           
Flag Coverage Δ
unit 46.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mattrunyon mattrunyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug w/ input for file is sweet. Just a few small things

package.json Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@mattrunyon mattrunyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait 1 more suggestion. Only run unit tests, not all tests. Add --config jest.config.unit.cjs to the command in both spots

@bmingles bmingles merged commit 80f29f5 into deephaven:main Nov 7, 2023
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jest - Debugging Script
2 participants