feat: Add ResizeObserver to Grid and Chart #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ResizeObserver is now widely available in all browsers, so use it to listen for resizing of our grid and plot elements - Pull `grid-wrapper` from `IrisGrid` and put it directly in `Grid` - Now `Grid` doesn't have to listen to the "parent" element, which was kind of strange in the first place. - Tested by opening up some tables and charts, resizing the panels and ensuring they updated correctly.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1626 +/- ##
==========================================
- Coverage 46.71% 46.70% -0.02%
==========================================
Files 583 584 +1
Lines 36308 36317 +9
Branches 9094 9098 +4
==========================================
Hits 16961 16961
- Misses 19295 19304 +9
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
mattrunyon
requested changes
Nov 6, 2023
mattrunyon
approved these changes
Nov 7, 2023
|
@mattrunyon updated so you can see the full error message from the UI: |
|
Right you are - updated the other PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grid-wrapperfromIrisGridand put it directly inGridGriddoesn't have to listen to the "parent" element, which was kind of strange in the first place.