fix: Theming - switched from ?inline to ?raw css imports #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1600 +/- ##
==========================================
- Coverage 46.74% 46.74% -0.01%
==========================================
Files 583 583
Lines 36256 36265 +9
Branches 9072 9072
==========================================
+ Hits 16947 16951 +4
- Misses 19257 19262 +5
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
mofojed
previously approved these changes
Oct 27, 2023
Comment on lines
+21
to
+38
| * e.g. | ||
| * | ||
| * :root { | ||
| * --dh-color-from-light-palette: #fff; | ||
| * --dh-color-from-light-palette2: #ccc; | ||
| * } | ||
| * :root { | ||
| * --dh-color-from-light-semantic: #000; | ||
| * } | ||
| * :root { | ||
| * --dh-color-from-light-semantic-editor: #000; | ||
| * } | ||
| * :root { | ||
| * --dh-color-from-light-semantic-grid: #000; | ||
| * } | ||
| * :root { | ||
| * --dh-color-from-light-components: #000; | ||
| * } |
There was a problem hiding this comment.
Not sure where this example came from?
There was a problem hiding this comment.
It's just an example of concatenation of themes (modified from the comment in the dark one). Once light theme is actually implemented there will be multiple imports
mattrunyon
approved these changes
Oct 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that Enterprise does not handle css ?inline css imports in node_modules the same way it does in src. Namely, the raw content gets imported as an empty string instead of the raw content.
fixes #1599
BREAKING CHANGE: Theme css imports were switched from
?inlineto?raw. Not likely that we have any consumers yet, but this would impact webpack config.