-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove @deephaven/app-utils from @deephaven/dashboard-core-plugins dependency list #1596
Conversation
…ns dependency list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left 2 comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1596 +/- ##
==========================================
+ Coverage 46.65% 46.74% +0.09%
==========================================
Files 575 583 +8
Lines 36189 36256 +67
Branches 9063 9072 +9
==========================================
+ Hits 16883 16947 +64
- Misses 19254 19257 +3
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Fixes #1593
I don't think these breaking changes should affect enterprise since it doesn't use
@deephaven/app-utils
BREAKING CHANGE:
usePlugins
andPluginsContext
were moved from@deephaven/app-utils
to@deephaven/plugin
.useLoadTablePlugin
was moved from@deephaven/app-utils
to@deephaven/dashboard-core-plugins
.useConnection
andConnectionContext
were moved from@deephaven/app-utils
to@deephaven/jsapi-components
.DeephavenPluginModuleMap
was removed from@deephaven/redux
. UsePluginModuleMap
from@deephaven/plugin
instead.