Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Plugin peer dependencies do not get versions from lerna #1517

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

mattrunyon
Copy link
Collaborator

Apparently lerna doesn't treat file items in peer dependencies the same as it does for regular or dev dependencies. They don't get replaced and make the peer dependency unfindable.

Compare these 2. In peer dependencies for plugin it lists file:../dashboard instead of an actual version. But for regular dependencies in components, they get a version.

https://unpkg.com/@deephaven/plugin@0.48.0/package.json
https://unpkg.com/@deephaven/components@0.48.0/package.json

@mattrunyon mattrunyon self-assigned this Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a1de0f6) 46.42% compared to head (cb184c8) 46.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1517   +/-   ##
=======================================
  Coverage   46.42%   46.42%           
=======================================
  Files         558      558           
  Lines       35714    35714           
  Branches     8916     8916           
=======================================
  Hits        16582    16582           
  Misses      19082    19082           
  Partials       50       50           
Flag Coverage Δ
unit 46.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofojed mofojed merged commit 322f6ff into deephaven:main Sep 15, 2023
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2023
@mattrunyon mattrunyon deleted the plugin-peer-dep-fix branch June 23, 2024 06:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants