Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quick filter focus text doesn't match canvas text #1475

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Conversation

dsmmcken
Copy link
Contributor

@dsmmcken dsmmcken commented Aug 31, 2023

resolves: #1472

looks like tnum wasn't being inherited.

@dsmmcken dsmmcken requested a review from mofojed August 31, 2023 14:39
@dsmmcken dsmmcken self-assigned this Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d59e9be) 45.74% compared to head (759d405) 45.74%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1475   +/-   ##
=======================================
  Coverage   45.74%   45.74%           
=======================================
  Files         516      516           
  Lines       35095    35095           
  Branches     8785     8785           
=======================================
  Hits        16055    16055           
  Misses      18989    18989           
  Partials       51       51           
Flag Coverage Δ
unit 45.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that this is only a problem with updated Chrome/Playwright?

However, with this fix I'm now seeing strange behaviour in Firefox:
font-issue-review-firefox
Chrome still shifts by a couple pixels, and can fix that by changing the top padding in .iris-grid-input-field to 5px...
font-issue-review-chrome

@dsmmcken
Copy link
Contributor Author

Chrome still shifts by a couple pixels, and can fix that by changing the top padding in .iris-grid-input-field to 5px...

That massively mis-aligns it for me in chrome/win the opposite direction.

@dsmmcken dsmmcken linked an issue Sep 1, 2023 that may be closed by this pull request
@dsmmcken
Copy link
Contributor Author

dsmmcken commented Sep 1, 2023

I am guessing we are running up against platform limitations. I adjusted so it's right in chrome/firefox on windows, but I don't think we can get it perfect against the matrix of OS and browsers. Does it look reasonable to you on linux or is it way off still?

Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect for me on Ubuntu in both Firefox and Chrome. Mac it shifts up/down by a pixel or two, but fonts look the same.

I think just rebase off the latest and update snapshots then this is good to go. Thanks!

@dsmmcken dsmmcken enabled auto-merge (squash) September 1, 2023 20:38
@dsmmcken dsmmcken merged commit 02841b5 into main Sep 7, 2023
5 checks passed
@dsmmcken dsmmcken deleted the dmckenzie_1472 branch September 7, 2023 13:54
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quick filter font doesn't match in Chrome
2 participants