Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added containsIgnoreCase to FilterValue interface #1426

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

bmingles
Copy link
Contributor

@bmingles bmingles commented Jul 28, 2023

Added containsIgnoreCase to FilterValue interface
resolves #1425

@bmingles bmingles requested a review from mattrunyon July 28, 2023 16:13
@bmingles bmingles changed the title Added containsIgnoreCase to FilterValue interface feat: Added containsIgnoreCase to FilterValue interface Jul 28, 2023
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #1426 (a35e89f) into main (3247d27) will not change coverage.
The diff coverage is n/a.

❗ Current head a35e89f differs from pull request most recent head 9ad18e2. Consider uploading reports for the commit 9ad18e2 to get more accurate results

@@           Coverage Diff           @@
##             main    #1426   +/-   ##
=======================================
  Coverage   45.71%   45.71%           
=======================================
  Files         511      511           
  Lines       35065    35065           
  Branches     8767     8767           
=======================================
  Hits        16029    16029           
  Misses      18985    18985           
  Partials       51       51           
Flag Coverage Δ
unit 45.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@mattrunyon mattrunyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're here, there's also matches and matchesIgnoreCase in the JS AP that I saw. Add those. Same signatures as contains

@bmingles bmingles requested a review from mattrunyon July 28, 2023 16:31
@bmingles bmingles merged commit d131b05 into deephaven:main Jul 28, 2023
4 checks passed
@bmingles bmingles deleted the 1425-contains-ignore-case-types branch July 28, 2023 16:55
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add containsIgnoreCase to dh.types
2 participants