-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert: adding back "Table rendering support for databars (#1212)" #1365
Conversation
@@ -496,7 +496,7 @@ class IrisGridTableModelTemplate< | |||
} | |||
} | |||
|
|||
textValueForCell(x: ModelIndex, y: ModelIndex): string | null { | |||
textValueForCell(x: ModelIndex, y: ModelIndex): string | null | undefined { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is 1 of 2 functions that I changed from original
Codecov Report
@@ Coverage Diff @@
## main #1365 +/- ##
==========================================
- Coverage 45.95% 45.52% -0.44%
==========================================
Files 494 506 +12
Lines 34422 34888 +466
Branches 8586 8708 +122
==========================================
+ Hits 15820 15884 +64
- Misses 18551 18953 +402
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -2011,7 +2025,7 @@ class IrisGridTableModelTemplate< | |||
} | |||
} | |||
|
|||
editValueForCell(x: ModelIndex, y: ModelIndex): string | null { | |||
editValueForCell(x: ModelIndex, y: ModelIndex): string | null | undefined { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the other
Not sure if I need to mention a ticket number here?