revert: adding back "Table rendering support for databars (#1212)" #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanalvizo
commented
Jun 9, 2023
| @@ -496,7 +496,7 @@ class IrisGridTableModelTemplate< | |||
| } | |||
| } | |||
|
|
|||
| textValueForCell(x: ModelIndex, y: ModelIndex): string | null { | |||
| textValueForCell(x: ModelIndex, y: ModelIndex): string | null | undefined { | |||
There was a problem hiding this comment.
this is 1 of 2 functions that I changed from original
Codecov Report
@@ Coverage Diff @@
## main #1365 +/- ##
==========================================
- Coverage 45.95% 45.52% -0.44%
==========================================
Files 494 506 +12
Lines 34422 34888 +466
Branches 8586 8708 +122
==========================================
+ Hits 15820 15884 +64
- Misses 18551 18953 +402
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ethanalvizo
commented
Jun 9, 2023
| @@ -2011,7 +2025,7 @@ class IrisGridTableModelTemplate< | |||
| } | |||
| } | |||
|
|
|||
| editValueForCell(x: ModelIndex, y: ModelIndex): string | null { | |||
| editValueForCell(x: ModelIndex, y: ModelIndex): string | null | undefined { | |||
There was a problem hiding this comment.
this is the other
mofojed
approved these changes
Jun 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if I need to mention a ticket number here?