feat: improvements to null and empty strings filters in grid #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address some concerns from #1243. - advanced styling for null and empty strings - quick filter input styling for null and empty strings - context menu styling for null and empty strings - escape the null when using filter by menu - New special empty string context menu - Fixed broken startswith/endwith - Allow empty string search as just "=" or "!=" Backslashes are still broken, and context menu selection doesn't escape the quick filter correctly.
Codecov Report
@@ Coverage Diff @@
## main #1348 +/- ##
==========================================
- Coverage 45.95% 45.58% -0.38%
==========================================
Files 494 506 +12
Lines 34422 34966 +544
Branches 8586 8734 +148
==========================================
+ Hits 15820 15940 +120
- Misses 18551 18975 +424
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
I don't think I like the input styling for nulls, since it can't be rich text so it would never work on something like null && !=AAPL. Will probably remove that feature. |
mofojed
requested changes
Jun 14, 2023
packages/iris-grid/src/mousehandlers/IrisGridContextMenuHandler.tsx
Outdated
Show resolved
Hide resolved
packages/iris-grid/src/mousehandlers/IrisGridContextMenuHandler.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Mike Bender <mikebender@deephaven.io>
mofojed
approved these changes
Jun 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1243
quick filter input styling for null and empty stringsAny filter containing a backslashes however is still broken in the jsapi deephaven/deephaven-core#3912