-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improvements to null and empty strings filters in grid #1348
Conversation
Address some concerns from #1243. - advanced styling for null and empty strings - quick filter input styling for null and empty strings - context menu styling for null and empty strings - escape the null when using filter by menu - New special empty string context menu - Fixed broken startswith/endwith - Allow empty string search as just "=" or "!=" Backslashes are still broken, and context menu selection doesn't escape the quick filter correctly.
Codecov Report
@@ Coverage Diff @@
## main #1348 +/- ##
==========================================
- Coverage 45.95% 45.58% -0.38%
==========================================
Files 494 506 +12
Lines 34422 34966 +544
Branches 8586 8734 +148
==========================================
+ Hits 15820 15940 +120
- Misses 18551 18975 +424
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I don't think I like the input styling for nulls, since it can't be rich text so it would never work on something like null && !=AAPL. Will probably remove that feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good overall, some cleanup
packages/iris-grid/src/mousehandlers/IrisGridContextMenuHandler.tsx
Outdated
Show resolved
Hide resolved
packages/iris-grid/src/mousehandlers/IrisGridContextMenuHandler.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Mike Bender <mikebender@deephaven.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the "Fixes #1243" to the description so it links properly? Then I'll approve.
Fixes #1243
quick filter input styling for null and empty stringsAny filter containing a backslashes however is still broken in the jsapi deephaven/deephaven-core#3912