Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add uncaught rejections to support logs #1293

Merged

Conversation

ethanalvizo
Copy link
Contributor

@ethanalvizo ethanalvizo commented May 12, 2023

Closes #1253

  • sample output logs: console.txt
  • search for "can't handle this - ethan"

@ethanalvizo ethanalvizo self-assigned this May 12, 2023
@ethanalvizo ethanalvizo force-pushed the 1253-uncaught-promise-reject branch from fa955df to 4a7c3d2 Compare May 12, 2023 16:47
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #1293 (4a7c3d2) into main (02215b6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1293   +/-   ##
=======================================
  Coverage   45.49%   45.49%           
=======================================
  Files         504      504           
  Lines       34826    34826           
  Branches     8688     8688           
=======================================
  Hits        15844    15844           
  Misses      18931    18931           
  Partials       51       51           
Flag Coverage Δ
unit 45.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ethanalvizo ethanalvizo requested a review from mofojed May 12, 2023 16:59
@ethanalvizo ethanalvizo merged commit 29ed459 into deephaven:main May 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add uncaught errors to support logs
2 participants