Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: DH-14630: useDebouncedViewportSearch: memoization bug #1273

Merged
merged 2 commits into from
May 9, 2023
Merged

fix: DH-14630: useDebouncedViewportSearch: memoization bug #1273

merged 2 commits into from
May 9, 2023

Conversation

bmingles
Copy link
Contributor

@bmingles bmingles commented May 8, 2023

Supports DH-14630

fixes #1272

@bmingles bmingles marked this pull request as ready for review May 8, 2023 16:43
@bmingles bmingles requested a review from mofojed May 8, 2023 16:43
@codecov
Copy link

codecov bot commented May 8, 2023 •
edited
Loading

Codecov Report

Merging #1273 (ec354d4) into main (588cb8f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1273   +/-   ##
=======================================
  Coverage   45.43%   45.43%           
=======================================
  Files         502      502           
  Lines       34764    34768    +4     
  Branches     8679     8679           
=======================================
+ Hits        15794    15798    +4     
  Misses      18919    18919           
  Partials       51       51
Flag Coverage Δ
unit 45.43% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../jsapi-components/src/useInitializeViewportData.ts 100.00% <ø> (ø)
packages/jsapi-components/src/useViewportData.ts 100.00% <ø> (ø)
...jsapi-components/src/useDebouncedViewportSearch.ts 100.00% <100.00%> (ø)

@bmingles bmingles force-pushed the web_DH-14630_useDebouncedViewportSearch-remove-cancel branch from 22eacfa to 323ad5d Compare May 8, 2023 17:09
@bmingles bmingles changed the title fix: DH-14630: useDebouncedViewportSearch: removed cancel effect fix: DH-14630: useDebouncedViewportSearch: memoization bug May 8, 2023
@vbabich
Copy link
Collaborator

vbabich commented May 8, 2023

Can we merge this after #1262?

mofojed
mofojed requested changes May 8, 2023
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for Vlad's merge

@bmingles
Copy link
Contributor Author

bmingles commented May 8, 2023

#1262

@vbabich Yes. Mind letting me know once it's merged?

@vbabich
Copy link
Collaborator

vbabich commented May 8, 2023

@bmingles #1262 merged

mofojed
mofojed reviewed May 9, 2023
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to clean up conflicts

@bmingles bmingles force-pushed the web_DH-14630_useDebouncedViewportSearch-remove-cancel branch from f1a2555 to ec354d4 Compare May 9, 2023 13:50
@bmingles bmingles requested a review from mofojed May 9, 2023 13:51
@bmingles bmingles merged commit be82b14 into deephaven:main May 9, 2023
@bmingles bmingles deleted the web_DH-14630_useDebouncedViewportSearch-remove-cancel branch May 9, 2023 14:20
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mofojed mofojed mofojed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DH-14630: useDebouncedViewportSearch - memoization bug
3 participants
@bmingles @vbabich @mofojed