Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Context menu does not appear when right-clicking IrisGrid component in styleguide #1184

Conversation

emilyhuxng
Copy link
Contributor

Fixes #1065

Context menu was being rendered but it was rendered based on the page x and y, so since you have to scroll to the bottom to see IrisGrid, the context menu was being rendered off the screen.

@emilyhuxng emilyhuxng added this to the March 2023 milestone Mar 29, 2023
@emilyhuxng emilyhuxng requested a review from mofojed March 29, 2023 18:09
@emilyhuxng emilyhuxng self-assigned this Mar 29, 2023
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@emilyhuxng emilyhuxng merged commit 696cc2d into deephaven:main Mar 29, 2023
@emilyhuxng emilyhuxng deleted the bug-1065-context-menu-does-not-aooear-when-right-clicking-iris-grid-in-style-guide branch March 29, 2023 18:53
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Context menu does not appear when right-clicking IrisGrid component in styleguide
2 participants