Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ordering of subplots #1111

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Feb 27, 2023

  • User is expecting the plots to be ordered 0 at top, increasing downward
  • Plotlys bounds coordinate system has 0,0 in the bottom left, increasing upward
  • Invert the coordinates so that it appears in plotly correctly
  • Add unit tests

- User is expecting the plots to be ordered 0 at top, increasing downward
- Plotlys bounds coordinate system has 0,0 in the bottom left, increasing upward
- Invert the coordinates so that it appears in plotly correctly
- Add unit tests
@mofojed mofojed added the bug Something isn't working label Feb 27, 2023
@mofojed mofojed added this to the February 2023 milestone Feb 27, 2023
@mofojed mofojed self-assigned this Feb 27, 2023
@mofojed mofojed marked this pull request as ready for review February 27, 2023 18:42
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #1111 (80caca5) into main (144605a) will increase coverage by 0.47%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1111      +/-   ##
==========================================
+ Coverage   42.91%   43.38%   +0.47%     
==========================================
  Files         434      434              
  Lines       32596    32621      +25     
  Branches     8202     8222      +20     
==========================================
+ Hits        13989    14154     +165     
+ Misses      18558    18418     -140     
  Partials       49       49              
Flag Coverage Δ
unit 43.38% <100.00%> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/chart/src/ChartTestUtils.ts 93.61% <100.00%> (+0.93%) ⬆️
packages/chart/src/ChartUtils.ts 64.41% <100.00%> (+0.18%) ⬆️
...sidebar/conditional-formatting/ConditionEditor.tsx 8.00% <0.00%> (-0.28%) ⬇️
...ebar/conditional-formatting/ColumnFormatEditor.tsx 3.70% <0.00%> (-0.22%) ⬇️
packages/jsapi-utils/src/TableUtils.ts 53.43% <0.00%> (-0.02%) ⬇️
...udio/src/settings/ColumnSpecificSectionContent.tsx 98.73% <0.00%> (ø)
...nditional-formatting/ConditionalFormattingUtils.ts 27.58% <0.00%> (+1.27%) ⬆️
packages/components/src/Button.tsx 76.31% <0.00%> (+5.26%) ⬆️
packages/components/src/BasicModal.tsx 58.33% <0.00%> (+8.33%) ⬆️
packages/utils/src/PromiseUtils.ts 95.65% <0.00%> (+17.39%) ⬆️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mofojed mofojed merged commit c4a3795 into deephaven:main Mar 2, 2023
@mofojed mofojed deleted the fix-subplots-ordering branch March 2, 2023 17:01
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants