Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clicking a folder in file explorer panel sometimes fails to open or close it #1099

Merged

Conversation

jason-wang24
Copy link
Contributor

Fixes #1085

  • isDragging was always set to true on itemMouseMove which prevented onSelect from firing on even the slightest of mouse movements while clicking
  • Set isDragging to true only if the mouse moves at least 5 viewport units in the X or Y direction between the mouseDown and mouseUp events (attempted to get this value as close as possible to when the UI changes to indicate dragging)

@jason-wang24 jason-wang24 self-assigned this Feb 20, 2023
@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #1099 (924326a) into main (9aab657) will increase coverage by 0.00%.
The diff coverage is 85.71%.

@@           Coverage Diff           @@
##             main    #1099   +/-   ##
=======================================
  Coverage   42.91%   42.91%           
=======================================
  Files         434      434           
  Lines       32593    32597    +4     
  Branches     8198     8201    +3     
=======================================
+ Hits        13987    13990    +3     
- Misses      18557    18558    +1     
  Partials       49       49           
Flag Coverage Δ
unit 42.91% <85.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/components/src/ItemList.tsx 73.92% <85.71%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jason-wang24 jason-wang24 merged commit 7a7fc14 into deephaven:main Feb 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking a folder in file explorer panel sometimes fails to open or close it
2 participants