From d852e495a81c26a9273d6f8a72d4ea9fe9a04668 Mon Sep 17 00:00:00 2001
From: Don <donmckenzie@deephaven.io>
Date: Wed, 1 Mar 2023 09:23:26 -0500
Subject: [PATCH] feat: Improve text labels based on suggestions from chatGPT
 (#1118)

I asked chatGPT to help me brainstorm improvements to some of the labels
and hint text based on the Apple Human Interface Guidelines. I then
edited them as human to improve them further.

Review and let me know if you think any are worse or weird.

---------

Co-authored-by: Mike Bender <mikebender@deephaven.io>
---
 .../src/settings/ColumnSpecificSectionContent.tsx        | 5 ++---
 .../src/settings/FormattingSectionContent.tsx            | 4 ++--
 packages/code-studio/src/settings/SettingsMenu.tsx       | 4 ++--
 .../code-studio/src/settings/ShortcutsSectionContent.tsx | 4 ++--
 packages/iris-grid/src/IrisGrid.tsx                      | 2 +-
 packages/iris-grid/src/sidebar/AdvancedSettingsMenu.tsx  | 4 ++--
 packages/iris-grid/src/sidebar/RollupRows.tsx            | 4 ++--
 packages/iris-grid/src/sidebar/SelectDistinctBuilder.tsx | 9 +++------
 8 files changed, 16 insertions(+), 20 deletions(-)

diff --git a/packages/code-studio/src/settings/ColumnSpecificSectionContent.tsx b/packages/code-studio/src/settings/ColumnSpecificSectionContent.tsx
index 525af78bf9..802e9e43de 100644
--- a/packages/code-studio/src/settings/ColumnSpecificSectionContent.tsx
+++ b/packages/code-studio/src/settings/ColumnSpecificSectionContent.tsx
@@ -614,10 +614,9 @@ export class ColumnSpecificSectionContent extends PureComponent<
 
     return (
       <div className="app-settings-formatting-section" ref={this.containerRef}>
-        <div>Default formatting for matched column names</div>
         <div className="app-settings-menu-description mb-3">
-          Applies a formatting rule to all columns that match a specified name
-          and type.
+          Customize the formatting of table columns by applying rules based on
+          matching both a column name and column type.
         </div>
 
         <TransitionGroup
diff --git a/packages/code-studio/src/settings/FormattingSectionContent.tsx b/packages/code-studio/src/settings/FormattingSectionContent.tsx
index 8c402a7476..7ba47ec4ff 100644
--- a/packages/code-studio/src/settings/FormattingSectionContent.tsx
+++ b/packages/code-studio/src/settings/FormattingSectionContent.tsx
@@ -429,9 +429,9 @@ export class FormattingSectionContent extends PureComponent<
     return (
       <div className="app-settings-formatting-section" ref={this.containerRef}>
         <div className="container-fluid p-0">
-          <div>Default formatting for column types</div>
           <div className="app-settings-menu-description mb-3">
-            Applies a formatting rule to all columns of a set type.
+            Choose the default formatting rule to apply to all table columns
+            based on their type.
           </div>
           <div className="form-row mb-2">
             <label
diff --git a/packages/code-studio/src/settings/SettingsMenu.tsx b/packages/code-studio/src/settings/SettingsMenu.tsx
index 96f6eb6f64..605f7f6b38 100644
--- a/packages/code-studio/src/settings/SettingsMenu.tsx
+++ b/packages/code-studio/src/settings/SettingsMenu.tsx
@@ -143,7 +143,7 @@ export class SettingsMenu extends Component<
                   transform="grow-4"
                   className="mr-2"
                 />
-                Default Formatting &amp; Time zone
+                Default Format &amp; Time zone
               </>
             }
             onToggle={this.handleSectionToggle}
@@ -163,7 +163,7 @@ export class SettingsMenu extends Component<
                   transform="grow-4"
                   className="mr-2"
                 />
-                Column Specific Formatting Rules
+                Format by Column Name &amp; Type
               </>
             }
             onToggle={this.handleSectionToggle}
diff --git a/packages/code-studio/src/settings/ShortcutsSectionContent.tsx b/packages/code-studio/src/settings/ShortcutsSectionContent.tsx
index b6ab988b74..6b5f8e8913 100644
--- a/packages/code-studio/src/settings/ShortcutsSectionContent.tsx
+++ b/packages/code-studio/src/settings/ShortcutsSectionContent.tsx
@@ -62,8 +62,8 @@ function ShortcutSectionContent({
   return (
     <>
       <div className="app-settings-menu-description">
-        Customize shortcuts below. Assigning shortcuts that conflict with the
-        browser or IDE shortcuts may cause unintended behavior
+        Customize shortcuts below. To prevent unexpected results, avoid
+        conflicting shortcuts with the browser or IDE editor.
       </div>
       {categories.map(category => (
         <ShortcutCategory
diff --git a/packages/iris-grid/src/IrisGrid.tsx b/packages/iris-grid/src/IrisGrid.tsx
index 7d47865229..2f26c57201 100644
--- a/packages/iris-grid/src/IrisGrid.tsx
+++ b/packages/iris-grid/src/IrisGrid.tsx
@@ -1075,7 +1075,7 @@ export class IrisGrid extends Component<IrisGridProps, IrisGridState> {
       }
       optionItems.push({
         type: OptionType.VISIBILITY_ORDERING_BUILDER,
-        title: 'Hide, Group, and Order Columns',
+        title: 'Organize Columns',
         icon: dhEye,
       });
       if (isFormatColumnsAvailable) {
diff --git a/packages/iris-grid/src/sidebar/AdvancedSettingsMenu.tsx b/packages/iris-grid/src/sidebar/AdvancedSettingsMenu.tsx
index d42794db7a..68089731d2 100644
--- a/packages/iris-grid/src/sidebar/AdvancedSettingsMenu.tsx
+++ b/packages/iris-grid/src/sidebar/AdvancedSettingsMenu.tsx
@@ -34,9 +34,9 @@ AdvancedSettingsMenu.getAdvancedSettingsTitleForKey = (
 ): string => {
   switch (key) {
     case AdvancedSettingsType.FILTER_CONTROL_CHANGE_CLEARS_ALL_FILTERS:
-      return 'Control filters clear existing table filters';
+      return 'Clear current table filters before applying new filters from a control';
     case AdvancedSettingsType.LINK_CHANGE_CLEARS_ALL_FILTERS:
-      return 'Inbound links clear existing table filters';
+      return 'Clear current table filters before applying new filters from an incoming link filter';
   }
 };
 
diff --git a/packages/iris-grid/src/sidebar/RollupRows.tsx b/packages/iris-grid/src/sidebar/RollupRows.tsx
index 180f51e7cd..046d2f7bb0 100644
--- a/packages/iris-grid/src/sidebar/RollupRows.tsx
+++ b/packages/iris-grid/src/sidebar/RollupRows.tsx
@@ -517,8 +517,8 @@ class RollupRows extends Component<RollupRowsProps, RollupRowsState> {
                     // eslint-disable-next-line react/jsx-props-no-spreading
                     {...provided.droppableProps}
                   >
-                    Create rollup by dragging columns here, from the available
-                    columns list below.
+                    To create a rollup, drag columns from the list below and
+                    drop them into this area.
                   </div>
                 )}
               </Droppable>
diff --git a/packages/iris-grid/src/sidebar/SelectDistinctBuilder.tsx b/packages/iris-grid/src/sidebar/SelectDistinctBuilder.tsx
index ccee5af7f3..69b96081d6 100644
--- a/packages/iris-grid/src/sidebar/SelectDistinctBuilder.tsx
+++ b/packages/iris-grid/src/sidebar/SelectDistinctBuilder.tsx
@@ -161,12 +161,9 @@ class SelectDistinctBuilder extends Component<
 
         <div className="select-distinct-builder-footer">
           <div className="select-distinct-builder-hint">
-            Modifies a table to show unique value from a column, same as{' '}
-            <span className="inline-code-snippet">
-              selectDistinct(&quot;Column&quot;)
-            </span>
-            . Filters will be reset and the resulting table will contain only
-            the selected columns above.
+            Display only unique values from the selected table columns. Note
+            that this will reset any filters and display only the selected
+            columns.
           </div>
         </div>
       </div>