diff --git a/packages/iris-grid/src/IrisGrid.tsx b/packages/iris-grid/src/IrisGrid.tsx index 9638504079..31b9218aa4 100644 --- a/packages/iris-grid/src/IrisGrid.tsx +++ b/packages/iris-grid/src/IrisGrid.tsx @@ -282,7 +282,7 @@ export interface IrisGridProps { onError: (error: unknown) => void; onDataSelected: (index: ModelIndex, map: Record) => void; onStateChange: (irisGridState: IrisGridState, gridState: GridState) => void; - onPartitionAppend: (partitionColumn: Column, value: string) => void; + onPartitionAppend?: (partitionColumn: Column, value: string) => void; onAdvancedSettingsChange: AdvancedSettingsMenuCallback; partition: string | null; partitionColumn: Column | null; @@ -459,7 +459,6 @@ export class IrisGrid extends Component { onDataSelected: (): void => undefined, onError: (): void => undefined, onStateChange: (): void => undefined, - onPartitionAppend: (): void => undefined, onAdvancedSettingsChange: (): void => undefined, partition: null, partitionColumn: null, @@ -2336,7 +2335,7 @@ export class IrisGrid extends Component { if (partitionColumn == null) { return; } - onPartitionAppend(partitionColumn, value); + onPartitionAppend?.(partitionColumn, value); } handlePartitionChange(partition: string): void { @@ -3865,6 +3864,7 @@ export class IrisGrid extends Component { onAdvancedSettingsChange, canDownloadCsv, onCreateChart, + onPartitionAppend, } = this.props; const { metricCalculator, @@ -4421,7 +4421,11 @@ export class IrisGrid extends Component { partition={partition} onChange={this.handlePartitionChange} onFetchAll={this.handlePartitionFetchAll} - onAppend={this.handlePartitionAppend} + onAppend={ + onPartitionAppend !== undefined + ? this.handlePartitionAppend + : undefined + } onDone={this.handlePartitionDone} /> )} diff --git a/packages/iris-grid/src/IrisGridPartitionSelector.tsx b/packages/iris-grid/src/IrisGridPartitionSelector.tsx index 9c5761aed8..c87c46cfab 100644 --- a/packages/iris-grid/src/IrisGridPartitionSelector.tsx +++ b/packages/iris-grid/src/IrisGridPartitionSelector.tsx @@ -18,7 +18,7 @@ interface IrisGridPartitionSelectorProps { table: Table; columnName: ColumnName; partition: string; - onAppend: (partition: string) => void; + onAppend?: (partition: string) => void; onFetchAll: () => void; onDone: (event?: React.MouseEvent) => void; onChange: (partition: string) => void; @@ -31,7 +31,6 @@ class IrisGridPartitionSelector extends Component< IrisGridPartitionSelectorState > { static defaultProps = { - onAppend: (): void => undefined, onChange: (): void => undefined, onFetchAll: (): void => undefined, onDone: (): void => undefined, @@ -73,7 +72,7 @@ class IrisGridPartitionSelector extends Component< const { onAppend } = this.props; const { partition } = this.state; - onAppend(partition); + onAppend?.(partition); } handleCloseClick(): void { @@ -155,7 +154,8 @@ class IrisGridPartitionSelector extends Component< } render(): JSX.Element { - const { columnName, dh, getFormattedString, onDone, table } = this.props; + const { columnName, dh, getFormattedString, onAppend, onDone, table } = + this.props; const { partition } = this.state; const partitionSelectorSearch = ( extends Component< > Ignore & Fetch All - + {onAppend !== undefined && ( + + )}