From 77bea7d2badbc37eb3259a85873d6f900a07be14 Mon Sep 17 00:00:00 2001 From: Akshat Jawne <69530774+AkshatJawne@users.noreply.github.com> Date: Fri, 31 May 2024 09:21:56 -0600 Subject: [PATCH] fix: Console error when opening context menu on tree table (#2047) Resolves https://github.com/deephaven/web-client-ui/issues/2029 **Changes Implemented:** - Added null check when call formatValue function, to ensure that it is only called when it is defined ``` --- .../iris-grid/src/IrisGridTreeTableModel.ts | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/packages/iris-grid/src/IrisGridTreeTableModel.ts b/packages/iris-grid/src/IrisGridTreeTableModel.ts index e0bada6cdc..f197b0c59a 100644 --- a/packages/iris-grid/src/IrisGridTreeTableModel.ts +++ b/packages/iris-grid/src/IrisGridTreeTableModel.ts @@ -176,15 +176,16 @@ class IrisGridTreeTableModel extends IrisGridTableModelTemplate< this.viewportData.rows[r - this.viewportData.offset]; assertNotNull(intersection.startColumn); assertNotNull(intersection.endColumn); - for ( - let c = intersection.startColumn; - c <= intersection.endColumn; - c += 1 - ) { - assertNotNull(formatValue); - resultRow.push( - formatValue(viewportRow.data.get(c)?.value, this.columns[c]) - ); + if (formatValue != null) { + for ( + let c = intersection.startColumn; + c <= intersection.endColumn; + c += 1 + ) { + resultRow.push( + formatValue(viewportRow.data.get(c)?.value, this.columns[c]) + ); + } } result.push(resultRow); }