From fe43aa773a43102b14ca05cc6a29340468d357a3 Mon Sep 17 00:00:00 2001 From: Devin Smith Date: Thu, 26 Oct 2023 13:16:55 -0700 Subject: [PATCH] Update release procedure to add jars as assets. Additionally, make sure that the JMH jar artifact is produced during the publish workflow. --- .github/workflows/publish.yml | 8 +++++++- RELEASE.md | 5 +++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index d01321b..1f61307 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -38,10 +38,16 @@ jobs: - name: Publish # Note: even though we specify org.gradle.parallel=false in our CI gradle.properties, we want to be explicit # here about no parallelism to ensure we don't create disjointed staging repositories. - run: ./gradlew --no-parallel publish + run: ./gradlew --no-parallel assemble publish env: ORG_GRADLE_PROJECT_ossrhUsername: ${{ secrets.SONATYPE_USERNAME }} ORG_GRADLE_PROJECT_ossrhPassword: ${{ secrets.SONATYPE_PASSWORD }} ORG_GRADLE_PROJECT_signingKey: ${{ secrets.CI_AT_DEEPHAVEN_KEY }} ORG_GRADLE_PROJECT_signingPassword: ${{ secrets.CI_AT_DEEPHAVEN_PASSWORD }} ORG_GRADLE_PROJECT_signingRequired: true + + - name: Upload Artifacts + uses: actions/upload-artifact@v3 + with: + path: | + **/build/libs/** diff --git a/RELEASE.md b/RELEASE.md index ca04b84..3fd044e 100644 --- a/RELEASE.md +++ b/RELEASE.md @@ -64,6 +64,9 @@ $ git push -u upstream release/vX.Y.Z ### 4. Monitor release The release will proceed with [GitHub Actions](https://github.com/deephaven/deephaven-csv/actions/workflows/publish.yml). +Upon completion, the publish workflow will upload the jars as artifacts. There should be 7 jars in total: +`deephaven-csv`'s `.jar`, `-javadoc.jar`, `-sources.jar`, and `-jmh.jar`; `deephaven-csv-fast-double-parser`'s `.jar`, +`-javadoc.jar`, and `-sources.jar`. Download these artifacts for later upload as part of the GitHub release. ### 5. Maven Central jars @@ -114,4 +117,6 @@ Create a new [GitHub release](https://github.com/deephaven/deephaven-csv/release The convention is to have the Release title of the form `vX.Y.Z` and to autogenerate the release notes in comparison to the previous release tag. +Upload the 7 jar artifacts downloaded from the publish workflow as assets for the release. + Hit the GitHub "Publish release" button.