Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup redundant proto generation for C++ client #6080

Closed
jcferretti opened this issue Sep 18, 2024 · 1 comment
Closed

Cleanup redundant proto generation for C++ client #6080

jcferretti opened this issue Sep 18, 2024 · 1 comment
Assignees
Labels
bug Something isn't working triage
Milestone

Comments

@jcferretti
Copy link
Member

The proto/ gradle targets generate protos for all languages (java, python, go and C++), but in the C++ case, the generated files are not used, but generated with a different script and checked in under cpp-client/deephaven/proto. Before #6073, a task was run to check the output of both was at least consistent; after 6073 and for reasons explained in that ticket, the task is disabled.

We need to decide and execute on a way to cleanup this duplicity and/or inconsistency. Alternatives are:

a. Once the protobuf fandango cleans up we can go back to the state before 6073 and re-enable the consistency check.
b. We can stop generating C++ for the proto/ gradle targets, and let C++ do its thing. I personally tend to favor this option, as I think it would be more flexible and no more risky (since we have tests and protbuf binary format is very stable) for each language to be able to do its own thing in terms of protobuf versions.
c. (orthogonal with the two above) we should consider removing the need to check in proto generated code in the C++ client, and just depend on its generation, like we do in other languages.

Assigning to colin from our agreement in the discussion for 6073.

@jcferretti jcferretti added bug Something isn't working triage labels Sep 18, 2024
@devinrsmith devinrsmith added this to the Triage milestone Sep 20, 2024
@jcferretti
Copy link
Member Author

Fixed as part of #6136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

No branches or pull requests

3 participants