Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support all java.lang.Math in the query language #5995

Open
29 tasks
chipkent opened this issue Aug 27, 2024 · 1 comment · May be fixed by #6110
Open
29 tasks

Support all java.lang.Math in the query language #5995

chipkent opened this issue Aug 27, 2024 · 1 comment · May be fixed by #6110
Assignees
@chipkent
Labels
feature request New feature or request triage
Milestone
Triage

Comments

@chipkent
Copy link
Member

chipkent commented Aug 27, 2024 •
edited by alexpeters1208
Loading

All java.lang.Math methods should be supported in the query language.

Methods known to be missing are:

  • addExact
  • atan2
  • cbrt
  • copySign
  • decrementExact
  • expm2
  • floorDiv
  • floorMod
  • getExponent
  • hypot
  • IEEEremainder
  • incrementExact
  • log10
  • log1p
  • multiplyExact
  • negateExact
  • nextAfter
  • nextDown
  • nextUp
  • scalb
  • sinh
  • subtractExact
  • tanh
  • toDegrees
  • toIntExact
  • toRadians
  • ulp
  • E (constant)
  • PI (constant)
@chipkent chipkent added feature request New feature or request triage labels Aug 27, 2024
@chipkent chipkent self-assigned this Aug 27, 2024
@devinrsmith devinrsmith added this to the Triage milestone Aug 27, 2024
@rcaudy
Copy link
Member

rcaudy commented Aug 28, 2024

It's not really clear whether null-awareness makes sense for all of these, and so there may be limited or negative value in wrapping some of these methods. Specifically:

  • nextAfter
  • nextUp
  • nextDown

@chipkent chipkent linked a pull request Sep 23, 2024 that will close this issue
Open
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chipkent chipkent

Labels
feature request New feature or request triage
Projects
None yet
Milestone
Triage
Development

Successfully merging a pull request may close this issue.

feat: Support all java.lang.Math in the query language chipkent/deephaven-core
3 participants
@chipkent @rcaudy @devinrsmith