From 6ff8d08fefc6dd9467c461ef3ce43af4ffd7e456 Mon Sep 17 00:00:00 2001
From: milan-deepfence <rkmilansingh@gmail.com>
Date: Fri, 24 Nov 2023 14:27:35 +0530
Subject: [PATCH] fix(2019): correctd advanced filters compliance for
 integration

---
 .../components/IntegrationForm.tsx            | 281 ++++++++++++------
 .../integrations/pages/IntegrationAdd.tsx     |  16 +
 2 files changed, 208 insertions(+), 89 deletions(-)

diff --git a/deepfence_frontend/apps/dashboard/src/features/integrations/components/IntegrationForm.tsx b/deepfence_frontend/apps/dashboard/src/features/integrations/components/IntegrationForm.tsx
index 66831d1e7a..94752e58fd 100644
--- a/deepfence_frontend/apps/dashboard/src/features/integrations/components/IntegrationForm.tsx
+++ b/deepfence_frontend/apps/dashboard/src/features/integrations/components/IntegrationForm.tsx
@@ -1,4 +1,4 @@
-import { useState } from 'react';
+import { useEffect, useState } from 'react';
 import { useFetcher, useParams } from 'react-router-dom';
 import {
   Button,
@@ -114,6 +114,14 @@ const isJiraIntegration = (integrationType: string) => {
   return integrationType && integrationType === IntegrationType.jira;
 };
 
+const isCloudComplianceNotification = (notificationType: string) => {
+  return notificationType && notificationType === 'Cloud Compliance';
+};
+
+const isComplianceNotification = (notificationType: string) => {
+  return notificationType && notificationType === 'Compliance';
+};
+
 const API_SCAN_TYPE_MAP: {
   [key: string]: ScanTypeEnum;
 } = {
@@ -124,7 +132,13 @@ const API_SCAN_TYPE_MAP: {
 };
 
 const scanTypes = ['Secret', 'Vulnerability', 'Malware'];
-const AdvancedFilters = ({ notificationType }: { notificationType: string }) => {
+const AdvancedFilters = ({
+  notificationType,
+  cloudProvider,
+}: {
+  notificationType: string;
+  cloudProvider?: string;
+}) => {
   // severity
   const [selectedSeverity, setSelectedSeverity] = useState([]);
 
@@ -137,65 +151,98 @@ const AdvancedFilters = ({ notificationType }: { notificationType: string }) =>
   const [containers, setContainers] = useState<string[]>([]);
   const [clusters, setClusters] = useState<string[]>([]);
 
+  const [selectedCloudAccounts, setSelectedCloudAccounts] = useState<string[]>([]);
+
+  useEffect(() => {
+    setSelectedSeverity([]);
+    setSelectedStatus([]);
+    setHosts([]);
+    setImages([]);
+    setContainers([]);
+    setClusters([]);
+    setSelectedCloudAccounts([]);
+  }, [notificationType, cloudProvider]);
+
   return (
     <div className="col-span-2 mt-6">
       <div className="flex dark:text-text-input-value ">
         <div className="text-h5">Advanced Filter (Optional)</div>
       </div>
       <div className="grid grid-cols-2 gap-y-8 gap-x-8 pt-4">
-        <SearchableHostList
-          scanType={API_SCAN_TYPE_MAP[notificationType]}
-          triggerVariant="select"
-          defaultSelectedHosts={hosts}
-          onChange={(value) => {
-            setHosts(value);
-          }}
-          onClearAll={() => {
-            setHosts([]);
-          }}
-          agentRunning={false}
-          active={false}
-        />
-
-        <SearchableContainerList
-          scanType={API_SCAN_TYPE_MAP[notificationType]}
-          triggerVariant="select"
-          defaultSelectedContainers={containers}
-          onChange={(value) => {
-            setContainers(value);
-          }}
-          onClearAll={() => {
-            setContainers([]);
-          }}
-          active={false}
-        />
-
-        <SearchableImageList
-          scanType={API_SCAN_TYPE_MAP[notificationType]}
-          triggerVariant="select"
-          defaultSelectedImages={images}
-          onChange={(value) => {
-            setImages(value);
-          }}
-          onClearAll={() => {
-            setImages([]);
-          }}
-        />
-
-        <SearchableClusterList
-          triggerVariant="select"
-          defaultSelectedClusters={clusters}
-          onChange={(value) => {
-            setClusters(value);
-          }}
-          onClearAll={() => {
-            setClusters([]);
-          }}
-          agentRunning={false}
-          active={false}
-        />
+        {isCloudComplianceNotification(notificationType) && cloudProvider ? (
+          <SearchableCloudAccountsList
+            label={`${cloudProvider} Account`}
+            triggerVariant="select"
+            defaultSelectedAccounts={selectedCloudAccounts}
+            cloudProvider={cloudProvider.toLowerCase() as 'aws' | 'gcp' | 'azure'}
+            onClearAll={() => {
+              setSelectedCloudAccounts([]);
+            }}
+            onChange={(value) => {
+              setSelectedCloudAccounts(value);
+            }}
+          />
+        ) : (
+          <SearchableHostList
+            scanType={API_SCAN_TYPE_MAP[notificationType]}
+            triggerVariant="select"
+            defaultSelectedHosts={hosts}
+            onChange={(value) => {
+              setHosts(value);
+            }}
+            onClearAll={() => {
+              setHosts([]);
+            }}
+            agentRunning={false}
+            active={false}
+          />
+        )}
+        {!isComplianceNotification(notificationType) &&
+          !isCloudComplianceNotification(notificationType) && (
+            <SearchableContainerList
+              scanType={API_SCAN_TYPE_MAP[notificationType]}
+              triggerVariant="select"
+              defaultSelectedContainers={containers}
+              onChange={(value) => {
+                setContainers(value);
+              }}
+              onClearAll={() => {
+                setContainers([]);
+              }}
+              active={false}
+            />
+          )}
+        {!isComplianceNotification(notificationType) &&
+          !isCloudComplianceNotification(notificationType) && (
+            <SearchableImageList
+              scanType={API_SCAN_TYPE_MAP[notificationType]}
+              triggerVariant="select"
+              defaultSelectedImages={images}
+              onChange={(value) => {
+                setImages(value);
+              }}
+              onClearAll={() => {
+                setImages([]);
+              }}
+            />
+          )}
+        {!isCloudComplianceNotification(notificationType) && (
+          <SearchableClusterList
+            triggerVariant="select"
+            defaultSelectedClusters={clusters}
+            onChange={(value) => {
+              setClusters(value);
+            }}
+            onClearAll={() => {
+              setClusters([]);
+            }}
+            agentRunning={false}
+            active={false}
+          />
+        )}
 
-        {notificationType === 'Compliance' || notificationType === 'CloudCompliance' ? (
+        {isComplianceNotification(notificationType) ||
+        isCloudComplianceNotification(notificationType) ? (
           <>
             <input
               type="text"
@@ -204,39 +251,64 @@ const AdvancedFilters = ({ notificationType }: { notificationType: string }) =>
               readOnly
               value={selectedStatus.length}
             />
-            <Listbox
-              variant="underline"
-              value={selectedStatus}
-              name="statusFilter"
-              onChange={(value) => {
-                setSelectedStatus(value);
-              }}
-              placeholder="Select status"
-              label="Select status"
-              multiple
-              clearAll="Clear"
-              onClearAll={() => setSelectedStatus([])}
-              getDisplayValue={(value) => {
-                return value && value.length ? `${value.length} selected` : '';
-              }}
-            >
-              <div className="px-3 pt-2 text-p3 text-gray-900 dark:text-text-text-and-icon">
-                Host
-              </div>
-              <ListboxOption value={'Alarm'}>Alarm</ListboxOption>
-              <ListboxOption value={'Note'}>Note</ListboxOption>
-              <ListboxOption value={'Ok'}>Ok</ListboxOption>
-              <div className="px-3 pt-4 text-p3 text-gray-900 dark:text-text-text-and-icon">
-                Cloud / Kubernetes
-              </div>
-              <ListboxOption value={'Pass'}>Pass</ListboxOption>
-              <ListboxOption value={'Skip'}>Skip</ListboxOption>
-              <ListboxOption value={'Warn'}>Warn</ListboxOption>
-              <div className="px-3 pt-4 text-p3 text-gray-900 dark:text-text-text-and-icon">
-                Common
-              </div>
-              <ListboxOption value={'Info'}>Info</ListboxOption>
-            </Listbox>
+            {isComplianceNotification(notificationType) && (
+              <Listbox
+                variant="underline"
+                value={selectedStatus}
+                name="statusFilter"
+                onChange={(value) => {
+                  setSelectedStatus(value);
+                }}
+                placeholder="Select status"
+                label="Select status"
+                multiple
+                clearAll="Clear"
+                onClearAll={() => setSelectedStatus([])}
+                getDisplayValue={(value) => {
+                  return value && value.length ? `${value.length} selected` : '';
+                }}
+              >
+                <div className="px-3 pt-2 text-p3 text-gray-900 dark:text-text-text-and-icon">
+                  Host
+                </div>
+                <ListboxOption value={'Alarm'}>Alarm</ListboxOption>
+                <ListboxOption value={'Note'}>Note</ListboxOption>
+                <ListboxOption value={'Ok'}>Ok</ListboxOption>
+                <div className="px-3 pt-4 text-p3 text-gray-900 dark:text-text-text-and-icon">
+                  Kubernetes
+                </div>
+                <ListboxOption value={'Pass'}>Pass</ListboxOption>
+                <ListboxOption value={'Skip'}>Skip</ListboxOption>
+                <ListboxOption value={'Warn'}>Warn</ListboxOption>
+                <div className="px-3 pt-4 text-p3 text-gray-900 dark:text-text-text-and-icon">
+                  Common
+                </div>
+                <ListboxOption value={'Info'}>Info</ListboxOption>
+              </Listbox>
+            )}
+            {isCloudComplianceNotification(notificationType) && (
+              <Listbox
+                variant="underline"
+                value={selectedStatus}
+                name="statusFilter"
+                onChange={(value) => {
+                  setSelectedStatus(value);
+                }}
+                placeholder="Select status"
+                label="Select status"
+                multiple
+                clearAll="Clear"
+                onClearAll={() => setSelectedStatus([])}
+                getDisplayValue={(value) => {
+                  return value && value.length ? `${value.length} selected` : '';
+                }}
+              >
+                <ListboxOption value={'Pass'}>Pass</ListboxOption>
+                <ListboxOption value={'Skip'}>Skip</ListboxOption>
+                <ListboxOption value={'Warn'}>Warn</ListboxOption>
+                <ListboxOption value={'Info'}>Info</ListboxOption>
+              </Listbox>
+            )}
           </>
         ) : null}
 
@@ -277,10 +349,17 @@ const AdvancedFilters = ({ notificationType }: { notificationType: string }) =>
   );
 };
 
-const notificationTypeList = ['Vulnerability', 'Secret', 'Malware', 'Compliance'];
+const notificationTypeList = [
+  'Vulnerability',
+  'Secret',
+  'Malware',
+  'Compliance',
+  'Cloud Compliance',
+];
 
 const NotificationType = ({ fieldErrors }: { fieldErrors?: Record<string, string> }) => {
   const [notificationType, setNotificationType] = useState<ScanTypeEnum | string>('');
+  const [cloud, setCloud] = useState<string>('AWS');
 
   const { integrationType } = useParams() as {
     integrationType: string;
@@ -328,6 +407,30 @@ const NotificationType = ({ fieldErrors }: { fieldErrors?: Record<string, string
         ) : null} */}
       </Listbox>
 
+      {isCloudComplianceNotification(notificationType) && (
+        <Listbox
+          variant="underline"
+          label="Select Provider"
+          value={cloud}
+          name="cloudType"
+          onChange={(value) => {
+            setCloud(value);
+          }}
+          placeholder="Select provider"
+          getDisplayValue={() => {
+            return cloud;
+          }}
+        >
+          {['AWS', 'GCP', 'AZURE'].map((cloud) => {
+            return (
+              <ListboxOption value={cloud} key={cloud}>
+                {cloud}
+              </ListboxOption>
+            );
+          })}
+        </Listbox>
+      )}
+
       {isCloudTrailNotification(notificationType) && <>Add Cloud trails here</>}
 
       {isUserActivityNotification(notificationType) && (
@@ -344,7 +447,7 @@ const NotificationType = ({ fieldErrors }: { fieldErrors?: Record<string, string
       {notificationType &&
       !isCloudTrailNotification(notificationType) &&
       !isUserActivityNotification(notificationType) ? (
-        <AdvancedFilters notificationType={notificationType} />
+        <AdvancedFilters notificationType={notificationType} cloudProvider={cloud} />
       ) : null}
       {notificationType &&
       isVulnerabilityNotification(notificationType) &&
diff --git a/deepfence_frontend/apps/dashboard/src/features/integrations/pages/IntegrationAdd.tsx b/deepfence_frontend/apps/dashboard/src/features/integrations/pages/IntegrationAdd.tsx
index b3fc96d941..dd2a5b86e6 100644
--- a/deepfence_frontend/apps/dashboard/src/features/integrations/pages/IntegrationAdd.tsx
+++ b/deepfence_frontend/apps/dashboard/src/features/integrations/pages/IntegrationAdd.tsx
@@ -194,6 +194,8 @@ const action = async ({ request, params }: ActionFunctionArgs): Promise<ActionDa
       _notificationType = 'CloudTrailAlert';
     } else if (_notificationType === 'User Activities') {
       _notificationType = 'UserActivities';
+    } else if (_notificationType === 'Cloud Compliance') {
+      _notificationType = 'CloudCompliance';
     }
 
     // filters
@@ -265,6 +267,8 @@ const action = async ({ request, params }: ActionFunctionArgs): Promise<ActionDa
       node_ids: [],
     };
 
+    const accountIds = getArrayTypeValuesFromFormData(formData, 'cloudAccountsFilter');
+
     const nodeIds = [];
 
     if (hostFilter.length) {
@@ -309,6 +313,17 @@ const action = async ({ request, params }: ActionFunctionArgs): Promise<ActionDa
       );
       nodeIds.push(..._clusters);
     }
+    if (accountIds.length) {
+      const _accounts: ModelNodeIdentifier[] = accountIds.map<ModelNodeIdentifier>(
+        (id) => {
+          return {
+            node_id: id,
+            node_type: ModelNodeIdentifierNodeTypeEnum.CloudAccount,
+          };
+        },
+      );
+      nodeIds.push(..._accounts);
+    }
     if (severityFilter.length) {
       const filters = _filters.fields_filters.contains_filter.filter_in;
       const newFilter = {
@@ -327,6 +342,7 @@ const action = async ({ request, params }: ActionFunctionArgs): Promise<ActionDa
       };
       _filters.fields_filters.contains_filter.filter_in = newFilter;
     }
+
     if (intervalFilter) {
       // TODO Add filters
     }