Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V2] Vuln Scans fail for registry image when started from scan result list #1482

Closed
1 of 6 tasks
saurabh2253 opened this issue Aug 29, 2023 · 3 comments · Fixed by #1553
Closed
1 of 6 tasks

[V2] Vuln Scans fail for registry image when started from scan result list #1482

saurabh2253 opened this issue Aug 29, 2023 · 3 comments · Fixed by #1553
Assignees
@saurabh2253 @milan-deepfence
Labels
bug Something isn't working needs-triage Indicates that issue is not yet triaged and assigned

Comments

@saurabh2253
Copy link
Contributor

Describe the bug
Vuln Scans fail for registry image when started from scan result list

To Reproduce
Steps to reproduce the behavior:

  1. Add a registry
  2. Scan any image x
  3. Go to Vulnerabilities -> Show All Scans
  4. Scan the image x again from the options on scan result row

Expected behavior
Scan should go through but fails.

Components/Services affected

  • UI/Frontend
  • API/Backend
  • Agent
  • Deployment/YAMLs
  • CI/CD Integration
  • Other (specify)

Additional context
Add any other context about the problem here.
@saurabh2253 saurabh2253 added bug Something isn't working needs-triage Indicates that issue is not yet triaged and assigned labels Aug 29, 2023
@saurabh2253 saurabh2253 self-assigned this Aug 29, 2023
@manV
Copy link
Member

manV commented Sep 12, 2023

@saurabh2253 can you please tell us what change needs to be made here?

@saurabh2253
Copy link
Contributor Author

UI is sending node_type:"container_image" instead of "image"

@manV
Copy link
Member

manV commented Sep 12, 2023

@saurabh2253 I think this API should hard fail with 400 if wrong node type is passed.

@ramanan-ravi ramanan-ravi mentioned this issue Sep 12, 2023
Open
@milan-deepfence milan-deepfence mentioned this issue Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saurabh2253 saurabh2253

@milan-deepfence milan-deepfence

Labels
bug Something isn't working needs-triage Indicates that issue is not yet triaged and assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(1482): start scan to send node type of image for container image … deepfence/ThreatMapper
3 participants
@saurabh2253 @manV @milan-deepfence