Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registering tickets with invalid vote choices should be possible #197

Closed
jholdstock opened this issue Nov 11, 2020 · 5 comments · Fixed by #199
Closed

Registering tickets with invalid vote choices should be possible #197

jholdstock opened this issue Nov 11, 2020 · 5 comments · Fixed by #199

Comments

@jholdstock
Copy link
Member

At the moment an error is returned if the client vote options do not match the servers

@xaur
Copy link

xaur commented Dec 5, 2020

@jholdstock can you please elaborate a bit why invalid vote choises should be allowed? And is there a mechanism to warn the user about that?

@jholdstock
Copy link
Member Author

The flow for decrediton is

  1. buy tickets
  2. get fee address from vspd
  3. pay fee to provided address

If the vsp returns an "invalid vote choice" error on step 3, the wallet user needs to take recovery steps:

  • If the choice is invalid because decrediton is out of date, the user needs to update their wallet and retry registering the tickets with the vsp.
  • If the choice is invalid because the server is out of date, the user either needs to bug the VSP operator to update, or they need to re-register their tickets with another VSP.

All the while - their tickets are not registered with any VSP and are at risk of being missed.

Allowing invalid vote choices removes all of the above UX friction, whilst introducing zero/minimal risks/compromises.

@jholdstock
Copy link
Member Author

I dont think we have any need for warnings or notifications on this. If a user wishes to vote on an upcoming agenda, they will need to update their dcrwallet/decrediton before they are able to set their vote preferences, otherwise the wallet will not have the new agenda listed.

@xaur
Copy link

xaur commented Dec 6, 2020

Thanks for elaborating! I agree the user will likely have updated wallet to vote on latest agendas. What about server, what happens if the server is out of date in this case?

@xaur
Copy link

xaur commented Dec 7, 2020

Oh and another question, does vspd (and dcrstakepool) have a field in their status endpoints to report the "vote choice" version (consensus version?) they are running that we could possibly show at the VSPs listing to ensure that VSPs are upgrading?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants