Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect identity error on modal. #2656

Closed
lukebp opened this issue Nov 16, 2021 · 7 comments · Fixed by #2659
Closed

Incorrect identity error on modal. #2656

lukebp opened this issue Nov 16, 2021 · 7 comments · Fixed by #2659
Labels
pre-release-bug A bug that was discovered prior to being released into a production environment.

Comments

@lukebp
Copy link
Member

lukebp commented Nov 16, 2021

The identity error is not being displayed correctly when the error is encountered on the billing status modal.

image

@lukebp lukebp added bug A bug that made it into a production environment. 91cfcc8 labels Nov 16, 2021
@tiagoalvesdulce
Copy link
Member

This is the error I'm seeing on my end:

Screen Shot 2021-11-16 at 15 23 18

@lukebp
Copy link
Member Author

lukebp commented Nov 16, 2021

@tiagoalvesdulce should this be the global identity error that we added?

#2623 (comment)

@lukebp
Copy link
Member Author

lukebp commented Nov 16, 2021

How did you reproduce the error? The error I posted was from a private window where the identity did not exist at all.

@tiagoalvesdulce
Copy link
Member

hmm, I ran pictl userkeyupdate and tried to set the billing status.

@lukebp
Copy link
Member Author

lukebp commented Nov 17, 2021

@tiagoalvesdulce so that's a different identity error (wrong user identity vs no user identity). Both should result in the global user error though that was added in 2623 and that tells the user how to fix the problem.

@lukebp lukebp added pre-release-bug A bug that was discovered prior to being released into a production environment. and removed bug A bug that made it into a production environment. labels Nov 17, 2021
@victorgcramos
Copy link
Member

I could reproduce it. On it! 🧑‍🏭

@lukebp
Copy link
Member Author

lukebp commented Nov 22, 2021

This bug was a result of #2623 failing to consider this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-release-bug A bug that was discovered prior to being released into a production environment.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants