Re-rendering and page positioning issues.

[lukebp]

Found a couple issues with external links in comments. The screen recordings refer to the GoDCR proposal.

1. Clicking on an external link in the comments section causes the screen to reposition itself at the top of the comments section. It should not do this.

tmp-2021-09-27_17.08.36.mp4

2. If the scrollToComments=true param is set (GoDCR example) then you also get a weird re-render flickering.

tmp-2021-09-27_17.11.58.mp4

3. Add a external link to the comment markdown editor, preview it, click on it in the preview. It closed the editor and moves the page position back to the top of the comments section. The comment markdown editor should not be closed and the screen should not be re-positions.

4. The page is also be repositioned when the login modal pops up.

tmp-2021-09-28_14.49.20.mp4

We need to put some time into smoothing all of this out. It makes the website janky and hard to use when things are constantly being re-rendered and moving the scroll position around.

[lukebp]

There appear to be multiple navigation issues related to the ?scrollToComments=true. This issue and #2620 can probably be addressed at the same time.

[victorgcramos]

Actually, the navigation re-rendering happens due to comments structure: It's currently bound to proposal scope due to #2549, so every time some proposal detail is getting updated, comments list will too. Since the modal is displayed in the current screen position, and the details page gets re-rendered every time, the modal will always be displayed at the top of the screen.

Although visual changes only affect the modal scrolling and stuff like that, fixing it will require a comments section refactoring so we get away with this regarded dependency from what I could conclude with my code analysis.

Any thoughts on this? @amass01 @tiagoalvesdulce