Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Under review pagination bug #2530

Closed
lukebp opened this issue Aug 10, 2021 · 1 comment · Fixed by #2552
Closed

Under review pagination bug #2530

lukebp opened this issue Aug 10, 2021 · 1 comment · Fixed by #2552
Labels
bug A bug that made it into a production environment.

Comments

@lukebp
Copy link
Member

lukebp commented Aug 10, 2021

This example was taken from test-proposals. The ticketvote inventory reply is shown below.

image

This is how the "Under Review" list view is populated.

tmp.mp4

The page size when retreiving proposals is a maximum of 5 proposals per request. Only 5 proposals are being retreived here, but its using two separate requests to do so despite. This is incorrect.

It should be seemlessly retrieving a page of proposals (5 proposals) per request. If there is not a full page of proposals for a particular vote status then it should move to the next vote status until it fills up a full page for the request. As the user scrolls down, it should continue to do this until it reaches the end of the unauthorized list.

If the array of tokens in the ticketvote inventory is equal to the inventory page size (20 tokens) then it indicates another inventory page should be retreived. It should not continue to the next vote status until all proposals have been retreived for the current vote status.

@lukebp lukebp added bug A bug that made it into a production environment. 91cfcc8 labels Aug 10, 2021
@vibros68
Copy link
Contributor

I am on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug that made it into a production environment.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants