Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings views updates #3613

Closed
MariaPleshkova opened this issue Dec 15, 2021 · 2 comments · Fixed by #3631
Closed

Settings views updates #3613

MariaPleshkova opened this issue Dec 15, 2021 · 2 comments · Fixed by #3631

Comments

@MariaPleshkova
Copy link

MariaPleshkova commented Dec 15, 2021

In the current release (1.6.3) all sections of Settings are on one page and, thus, a bit out of our components library (had to use subtitles within sections there, bit it's not the way we show them). So we reorganized the view a bit.
We split a view into 3 main parts (Connectivity, General, Privacy and Security) and reworked them into a tab view.
Here is an example from the Settings in Launcher:
image
Basically there are just 3 separate pages now, so all information is broken down into 3 categories(tabs). This way it's more clear where needed info is located.

For Settings in the Launcher we use two-columns grid for showing subitems on the page, because there's enough space for that:
image

What concerns Settings within an existing wallet, we mostly have to use one-column grid there (big left part of the screen is taken by the menu). But if there are short sections such as Timezone and Misc, then we can place both of them in one row.
image
image

For wider screens we can still always place 2 sections in a row:
image

And as there are already some tabs (Settings, Sources, Tutorials and Logs), we just split Settings tab into 3 new ones (Connectivity, General, Privacy and Security). So now there are 6 tab items in total.

Also we added the title ( Address Usage) above the Discover Address Usage button. This way it's more clear that this button is the separate option within Misc.

What concerns Privacy and Security tab, Private Passphrase updating is now out of the section, and the section with checkboxes is renamed to Outbound Connections.
image

Please, notice that we also added a new section with Launcher option ticker to the General tab. Describing what is this for in #3614 (point 4, when the wallet is launched)
image

P.S.There is a question to think about though. It is a save feature. Now the Save button is always out of the visible area (I need to scroll to see it). So initially I as a user have no idea that I have to click on it to save the changes.
So I see 2 options here:

1. Add an autosave feature after every change (that would be the best one in my opinion)
2. Add Save button below each section

Launcher Settings can be found within Concepting-Launcher page in Figma (see also 2 more pages to the right): https://www.figma.com/file/EanUbqJmPs8EMqY26j9zwo/decred---piui---decrediton?node-id=2978%3A11507

In-wallet settings design is within the Decrediton-Latest page:
https://www.figma.com/file/EanUbqJmPs8EMqY26j9zwo/decred---piui---decrediton?node-id=3103%3A12223

@bgptr
Copy link
Collaborator

bgptr commented Dec 22, 2021

on this

@MariaPleshkova
Copy link
Author

@bgptr added the latest discussed screenshots and description to the issue text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants