Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server/comms/test: noresponse send error #450

Closed
JoeGruffins opened this issue Jun 8, 2020 · 1 comment · Fixed by #493
Closed

server/comms/test: noresponse send error #450

JoeGruffins opened this issue Jun 8, 2020 · 1 comment · Fixed by #493

Comments

@JoeGruffins
Copy link
Member

Go CI 1.13 test failure.

log:

 ok  	decred.org/dcrdex/server/coinlock	1.788s
--- FAIL: TestOnline (0.92s)
    comms_test.go:708: noresponse send error: write tcp 127.0.0.1:44728->127.0.0.1:33797: write: connection reset by peer
FAIL
FAIL	decred.org/dcrdex/server/comms	1.203s
ok  	decred.org/dcrdex/server/db	1.746s

@chappjc comment:

It looks like the pingPeriod might be too fast or the pongWait too short vs pingPeriod in comms_test.go for the CI machines. 90 ms is a terribly fast ping period so I wouldn't be surprised if these pathetic CI machines just freeze for longer than that for no apparent reason. Otherwise I don't know why the conn write would have gotten connection reset by peer there.

If memory serves correctly, all of these sleep/wait related issues happen in 1.13. No hard evidence that this is causal, just an observation.

@chappjc
Copy link
Member

chappjc commented Apr 20, 2021

Resolved by #524

@chappjc chappjc closed this as completed Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants