Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: 0-qty market order(s) lurking in order book #2259

Closed
norwnd opened this issue Mar 27, 2023 · 4 comments
Closed

ui: 0-qty market order(s) lurking in order book #2259

norwnd opened this issue Mar 27, 2023 · 4 comments

Comments

@norwnd
Copy link
Contributor

norwnd commented Mar 27, 2023

Saw 0-qty market order show up in order book (on master mainnet, view-only mode = without creating account). It disappears and reappears (the amount of orders it consists of changes from time to time, could be just 1 or could be 5 for example, qty stays at 0 though) after page refresh or navigating from/to /markets page:

0-qty-market-order-in-the-book.webm

I tried to shake it off restarting dexc 2-3 times, it didn't help (ghost orders are still there) which suggests the server is either fully responsible or heavily contributing (e.g. order book gets corrupted when client fetches it from server) to this issue.

Full log: 0-qty-market-order.txt. No errors in console, running just 1 dexc instance (no funny stuff with 2 instances interfering with each other).

Might have same root cause as #1543, could potentially be resolved (or addressed at least partially) by: norwnd#1 + norwnd#2 + norwnd#4

@norwnd norwnd changed the title ui: 0-qty market order lurking in order book ui: 0-qty market order(s) lurking in order book Mar 27, 2023
@chappjc
Copy link
Member

chappjc commented Mar 27, 2023

Duplicate of #1929 which is also a dip of #1139

@chappjc
Copy link
Member

chappjc commented Mar 27, 2023

Duplicate of #1929 which is also a dup of #1139

@buck54321
Copy link
Member

It's not actually a zero-quantity market order. We combine the value of all market orders into that row, which should be hidden if the value is zero, but obviously have a bug.

@chappjc
Copy link
Member

chappjc commented Mar 27, 2023

This one is due to cancel orders, unlike the depth chart issues you solved in #1543 @buck54321
Let's close this since it's a dup

@chappjc chappjc closed this as not planned Won't fix, can't repro, duplicate, stale Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants