Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: core harness and loadbot tests need to be generalized #1565

Closed
buck54321 opened this issue Apr 6, 2022 · 3 comments · Fixed by #1656
Closed

testing: core harness and loadbot tests need to be generalized #1565

buck54321 opened this issue Apr 6, 2022 · 3 comments · Fixed by #1656
Assignees
@JoeGruffins
Labels
e2e testing End-to-end testing

Comments

@buck54321
Copy link
Member

If we host the implementation and claim support for the asset, it needs to go through the full range of testing. trade_simnet_test.go must be generalized for arbitrary asset pairs. Loadbot too.
@chappjc
Copy link
Member

chappjc commented Apr 6, 2022

Agree with that. At least with #1553 we have the "livetest" working for all clone assets, but the e2e tests in trade_simnet_test.go should work for any assets as well.

@JoeGruffins
Copy link
Member

Would kinda like to do this, unless someone has started.

@buck54321
Copy link
Member Author

@JoeGruffins I think core harness tests are the priority here. Loadbot is sorta messy, I think.

@buck54321 buck54321 added the e2e testing End-to-end testing label Apr 21, 2022
@JoeGruffins JoeGruffins mentioned this issue May 3, 2022
Merged
@JoeGruffins JoeGruffins mentioned this issue Jun 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoeGruffins JoeGruffins

Labels
e2e testing End-to-end testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

loadbot: Allow use with all markets. JoeGruffins/dcrdex
3 participants
@buck54321 @chappjc @JoeGruffins