Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: update for different reg fee assets #1220

Closed
chappjc opened this issue Sep 18, 2021 · 1 comment · Fixed by #1223
Closed

ui: update for different reg fee assets #1220

chappjc opened this issue Sep 18, 2021 · 1 comment · Fixed by #1223
Assignees

Comments

@chappjc
Copy link
Member

chappjc commented Sep 18, 2021

With registration fees accepted in different assets, as reported by the regFees field, the UI needs to be updated to allow selection of the fee asset according to what the server supports.

The workflow will also change a bit since DCR isn't required any more and the /register workflow should jump from init to add a dex instead of forcing a DCR wallet setup first.

Something that looks like this perhaps:

image

Originally posted by @chappjc in #1202 (comment)

@chappjc
Copy link
Member Author

chappjc commented Sep 21, 2021

@vctt94 is starting this. If anyone has started or has ideas, please comment now.

My general idea for how this dialog should work:

  • click on row of table, it will somehow show as selected, maybe a subtle highlight or boundary or different background
  • the New Wallet button I prototyped looks like crap though, so this should look nicer
  • when a row is clicked ideally some text will be shown above the Register button: "When you submit, a fee of "

So I guess some JS to handle the click action, which does the style change for the table and updates / creates the text I just mentioned

@chappjc chappjc linked a pull request Sep 29, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants