From 6b6a5441072e15ae5e0f88602287ddf8328845dd Mon Sep 17 00:00:00 2001 From: martonp Date: Thu, 9 Nov 2023 23:22:14 -0500 Subject: [PATCH] Buck review updates --- client/mm/libxc/binance.go | 2 +- client/mm/mm_arb_market_maker.go | 13 +++++++++++++ client/mm/mm_arb_market_maker_test.go | 2 +- 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/client/mm/libxc/binance.go b/client/mm/libxc/binance.go index 19c0596eea..8cdb6c2177 100644 --- a/client/mm/libxc/binance.go +++ b/client/mm/libxc/binance.go @@ -552,7 +552,7 @@ func (bnc *binance) requestInto(req *http.Request, thing interface{}) error { return nil } // TODO: use buffered reader - reader := io.LimitReader(resp.Body, 1<<20) + reader := io.LimitReader(resp.Body, 1<<22) r, err := io.ReadAll(reader) if err != nil { return err diff --git a/client/mm/mm_arb_market_maker.go b/client/mm/mm_arb_market_maker.go index e00d7a001c..0abb957aee 100644 --- a/client/mm/mm_arb_market_maker.go +++ b/client/mm/mm_arb_market_maker.go @@ -206,6 +206,19 @@ func (a *arbMarketMaker) processDEXOrderNote(note *core.OrderNote) { delete(a.ords, oid) delete(a.oidToPlacement, oid) a.ordMtx.Unlock() + + a.matchesMtx.Lock() + for _, match := range note.Order.Matches { + var matchID order.MatchID + copy(matchID[:], match.MatchID) + if a.matchesSeen[matchID] { + fmt.Printf("deleting seen match %s\n", matchID) + } else { + fmt.Printf("not deleting unseen match %s\n", matchID) + } + delete(a.matchesSeen, matchID) + } + a.matchesMtx.Unlock() } } diff --git a/client/mm/mm_arb_market_maker_test.go b/client/mm/mm_arb_market_maker_test.go index a72d772f87..04863c62be 100644 --- a/client/mm/mm_arb_market_maker_test.go +++ b/client/mm/mm_arb_market_maker_test.go @@ -708,7 +708,7 @@ func TestArbMarketMakerDEXUpdates(t *testing.T) { tests := []*test{ { - name: "one buy and one cell match notifications", + name: "one buy and one sell match notifications", orders: []*core.Order{ { ID: orderIDs[0][:],